From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] btrfs: do not ASSERT() when the fs flips RO inside btrfs_repair_io_failure()
Date: Tue, 27 Jan 2026 06:49:43 +0100 [thread overview]
Message-ID: <20260127054943.GA25269@lst.de> (raw)
In-Reply-To: <f21d342502c5ab027f38945fe06cda99af759784.1769491014.git.wqu@suse.com>
On Tue, Jan 27, 2026 at 03:46:55PM +1030, Qu Wenruo wrote:
> [BUG]
> There is a bug report that when btrfs hits ENOSPC error in a critical
> path, btrfs flips RO (this part is expected, although the ENOSPC bug
> still needs to be addressed).
>
> The problem is after the RO flip, if we trigger a read repair, we can
> hit the ASSERT() inside btrfs_repair_io_failure() like the following:
This makes the assert go away, and now the test seems to fail
consistently with:
output mismatch (see /root/xfstests-dev/results//btrfs/124.out.bad)
--- tests/btrfs/124.out 2024-08-19 04:21:17.339959767 +0000
+++ /root/xfstests-dev/results//btrfs/124.out.bad 2026-01-27 05:45:24.341140050 +0000
@@ -3,5 +3,11 @@
Write data with degraded mount
Mount normal and balance
+ERROR: error during balancing '/mnt/scratch': Read-only file system
+There may be more info in syslog - try dmesg | tail
on the mixes size setup. I guess this counts as:
Tested-by: Christoph Hellwig <hch@lst.de>
?
next prev parent reply other threads:[~2026-01-27 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 5:16 [PATCH] btrfs: do not ASSERT() when the fs flips RO inside btrfs_repair_io_failure() Qu Wenruo
2026-01-27 5:49 ` Christoph Hellwig [this message]
2026-02-04 14:07 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127054943.GA25269@lst.de \
--to=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox