public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Wang Yugui <wangyugui@e16-tech.com>
To: Boris Burkov <boris@bur.io>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v3 3/3] btrfs: forward declare btrfs_fs_info in volumes.h
Date: Tue, 27 Jan 2026 07:04:01 +0800	[thread overview]
Message-ID: <20260127070401.327D.409509F4@e16-tech.com> (raw)
In-Reply-To: <4c839922e88a33145eca264394ff8aab08c0a871.1769447820.git.boris@bur.io>

Hi,

> Fix the build warning:
> In file included from fs/btrfs/tests/chunk-allocation-tests.c:8:
> fs/btrfs/tests/../volumes.h:721:53: warning: ‘struct btrfs_space_info’ declared inside parameter list will not be visible outside of this definition or declaration
>   721 |                                              struct btrfs_space_info *space_info,
> 

Could we fold this patch into the patch 2/3 which introduce the file of 
chunk-allocation-tests.c?

Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2026/01/27



> Signed-off-by: Boris Burkov <boris@bur.io>
> ---
>  fs/btrfs/volumes.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index 8cb72e84dc84..ebc85bf53ee7 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -30,6 +30,7 @@ struct btrfs_block_group;
>  struct btrfs_trans_handle;
>  struct btrfs_transaction;
>  struct btrfs_zoned_device_info;
> +struct btrfs_space_info;
>  
>  #define BTRFS_MAX_DATA_CHUNK_SIZE	(10ULL * SZ_1G)
>  
> -- 
> 2.52.0
> 



  reply	other threads:[~2026-01-27  0:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 17:18 [PATCH v3 0/3] pending chunk allocation EEXIST fix Boris Burkov
2026-01-26 17:18 ` [PATCH v3 1/3] btrfs: fix EEXIST abort due to non-consecutive gaps in chunk allocation Boris Burkov
2026-01-26 17:18 ` [PATCH v3 2/3] btrfs: unit tests for pending extent walking functions Boris Burkov
2026-01-29  2:11   ` David Sterba
2026-01-26 17:18 ` [PATCH v3 3/3] btrfs: forward declare btrfs_fs_info in volumes.h Boris Burkov
2026-01-26 23:04   ` Wang Yugui [this message]
2026-01-27 19:02     ` Boris Burkov
2026-01-29  1:53       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260127070401.327D.409509F4@e16-tech.com \
    --to=wangyugui@e16-tech.com \
    --cc=boris@bur.io \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox