From: Christoph Hellwig <hch@lst.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
David Sterba <dsterba@suse.com>, Theodore Ts'o <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Andrey Albershteyn <aalbersh@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev
Subject: Re: [PATCH 09/16] fsverity: constify the vi pointer in fsverity_verification_context
Date: Wed, 28 Jan 2026 04:32:42 +0100 [thread overview]
Message-ID: <20260128033242.GA30830@lst.de> (raw)
In-Reply-To: <20260128032203.GA2718@sol>
On Tue, Jan 27, 2026 at 07:22:03PM -0800, Eric Biggers wrote:
> On Mon, Jan 26, 2026 at 05:50:55AM +0100, Christoph Hellwig wrote:
> > struct fsverity_info contains information that is only read in the
> > verification path. Apply the const qualifier to match various explicitly
> > passed arguments.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > fs/verity/verify.c | 15 ++++++++-------
> > 1 file changed, 8 insertions(+), 7 deletions(-)
>
> Did you consider that fsverity_info::hash_block_verified is written to?
> It's a pointer to an array, so the 'const' doesn't apply to its
> contents. But logically it's still part of the fsverity information.
Well, it doesn't apply by the type rules. But if you don't like the
const here just let me know and I'll drop it.
next prev parent reply other threads:[~2026-01-28 3:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 4:50 fsverity cleanups, speedup and memory usage optimization v3 Christoph Hellwig
2026-01-26 4:50 ` [PATCH 01/16] fs,fsverity: reject size changes on fsverity files in setattr_prepare Christoph Hellwig
2026-01-26 4:50 ` [PATCH 02/16] fs,fsverity: clear out fsverity_info from common code Christoph Hellwig
2026-01-26 4:50 ` [PATCH 03/16] ext4: don't build the fsverity work handler for !CONFIG_FS_VERITY Christoph Hellwig
2026-01-26 12:22 ` Jan Kara
2026-01-26 19:27 ` Darrick J. Wong
2026-01-26 4:50 ` [PATCH 04/16] f2fs: " Christoph Hellwig
2026-01-26 4:50 ` [PATCH 05/16] fsverity: pass struct file to ->write_merkle_tree_block Christoph Hellwig
2026-01-26 4:50 ` [PATCH 06/16] fsverity: start consolidating pagecache code Christoph Hellwig
2026-01-26 4:50 ` [PATCH 07/16] fsverity: don't issue readahead for non-ENOENT errors from __filemap_get_folio Christoph Hellwig
2026-01-26 19:11 ` Darrick J. Wong
2026-01-26 20:53 ` Eric Biggers
2026-01-27 6:00 ` Christoph Hellwig
2026-01-27 6:20 ` Eric Biggers
2026-01-27 6:28 ` Darrick J. Wong
2026-01-27 6:38 ` Christoph Hellwig
2026-01-28 0:57 ` Eric Biggers
2026-01-27 6:36 ` Christoph Hellwig
2026-01-26 4:50 ` [PATCH 08/16] fsverity: kick off hash readahead at data I/O submission time Christoph Hellwig
2026-01-26 19:26 ` Darrick J. Wong
2026-01-26 20:37 ` Eric Biggers
2026-01-26 4:50 ` [PATCH 09/16] fsverity: constify the vi pointer in fsverity_verification_context Christoph Hellwig
2026-01-26 19:13 ` Darrick J. Wong
2026-01-28 3:22 ` Eric Biggers
2026-01-28 3:32 ` Christoph Hellwig [this message]
2026-01-28 3:41 ` Eric Biggers
2026-01-28 3:48 ` Christoph Hellwig
2026-01-26 4:50 ` [PATCH 10/16] fsverity: deconstify the inode pointer in struct fsverity_info Christoph Hellwig
2026-01-26 19:13 ` Darrick J. Wong
2026-01-26 4:50 ` [PATCH 11/16] fsverity: push out fsverity_info lookup Christoph Hellwig
2026-01-26 4:50 ` [PATCH 12/16] fs: consolidate fsverity_info lookup in buffer.c Christoph Hellwig
2026-01-26 12:25 ` Jan Kara
2026-01-26 19:17 ` Darrick J. Wong
2026-01-26 4:50 ` [PATCH 13/16] ext4: consolidate fsverity_info lookup Christoph Hellwig
2026-01-26 12:27 ` Jan Kara
2026-01-26 4:51 ` [PATCH 14/16] f2fs: " Christoph Hellwig
2026-01-26 4:51 ` [PATCH 15/16] btrfs: " Christoph Hellwig
2026-01-26 4:51 ` [PATCH 16/16] fsverity: use a hashtable to find the fsverity_info Christoph Hellwig
2026-01-26 19:35 ` Darrick J. Wong
2026-01-26 20:40 ` Eric Biggers
2026-01-27 6:15 ` Christoph Hellwig
2026-01-28 3:28 ` Eric Biggers
2026-01-28 3:35 ` Christoph Hellwig
2026-01-28 3:44 ` Eric Biggers
2026-01-28 3:48 ` Christoph Hellwig
2026-01-28 3:59 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128033242.GA30830@lst.de \
--to=hch@lst.de \
--cc=aalbersh@redhat.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=dsterba@suse.com \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox