From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F9281A3029; Wed, 28 Jan 2026 03:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769571879; cv=none; b=QAukOcdtFnWWuIJJ4vlNkIDO4e0PbhrssMajXb1Me8ncZQgHjFZjfrawqQb3Qt97a4nfLoD0xL7ICd5kaU1IoJt0E2WtiicWXyh+ifAVYNrbZ8WlBMzjSsVJN/x2GesYr59FrCD6qTB6Nl5Qu2KVrt9uNnp09Yqae58/GQkoyNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769571879; c=relaxed/simple; bh=AxsbRiz6g5OHmI8dfGU8IScrv9tHBdspZu1p6bmeGBE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pf1kOo60kSC23J4fZhbRHcrJ149oZkR1+W2ehDNVDN8QM2+eb2IRGQlNPfQupiKernc1xKnLzWGbg9xXWfKctcvbbZ9K3CskJsD3uDxdkKpXvpfgdMYIYlAcX73i7+DgGJB0ddlI9bUawB/K4ZdQ97eKbHdYwDu7OXGCf7Xhw0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P201+ebc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P201+ebc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 388A4C4CEF1; Wed, 28 Jan 2026 03:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769571878; bh=AxsbRiz6g5OHmI8dfGU8IScrv9tHBdspZu1p6bmeGBE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P201+ebcahtveats5bhW2VJNT2y5qzZhA5UQq4K1H1t4r3j8dB204ErQtUZ4OVk7N YnWXZUkXX1CbW8uko3pPh+QLq4pWZLsSBJA9PvkIniP9ouFclwLqq3s7rzdJdnahiv F8uNjLjPV7RhubK6C9IlB690qAzIOrBIS168z1Jj9DAw594M2kV1u1lIAtTaU6frsL YVjDJT63xqbvutBpXCtTvsieBy0dKR44T1c1fyeRrNuX51xye8cn2hCQKzBf/PGuN2 y3G1FufZ7pMbsRJS+GieYovcevovNHI/9hjK7cqJDIpSxdqJz1BNQ/LggEt/fIz2Yr VqO+Ot3ttWEuA== Date: Tue, 27 Jan 2026 19:44:05 -0800 From: Eric Biggers To: Christoph Hellwig Cc: Al Viro , Christian Brauner , Jan Kara , David Sterba , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Andrey Albershteyn , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev Subject: Re: [PATCH 16/16] fsverity: use a hashtable to find the fsverity_info Message-ID: <20260128034405.GD2718@sol> References: <20260126045212.1381843-1-hch@lst.de> <20260126045212.1381843-17-hch@lst.de> <20260128032817.GB2718@sol> <20260128033519.GB30830@lst.de> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128033519.GB30830@lst.de> On Wed, Jan 28, 2026 at 04:35:19AM +0100, Christoph Hellwig wrote: > > Is there a reason for this function in particular to be __always_inline? > > fsverity_get_info() is just inline. > > Without the __always_inline some gcc versions on sparc fail to inline it, > and cause a link failure due to a reference to fsverity_readahead in > f2fs_mpage_readpages for non-verity builds. (reported by the buildbot) The relevant code is: vi = f2fs_need_verity(inode, folio->index); if (vi) fsverity_readahead(vi, folio, nr_pages); Where: f2fs_need_verity() => fsverity_get_info() => fsverity_active() If fsverity_active() needs __always_inline, why don't the other two functions in the call chain need it? - Eric