public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
	Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	David Sterba <dsterba@suse.com>, Theodore Ts'o <tytso@mit.edu>,
	Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
	Andrey Albershteyn <aalbersh@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev
Subject: Re: [PATCH 08/15] fsverity: kick off hash readahead at data I/O submission time
Date: Fri, 30 Jan 2026 06:55:41 +0100	[thread overview]
Message-ID: <20260130055541.GC622@lst.de> (raw)
In-Reply-To: <20260128232213.GJ5900@frogsfrogsfrogs>

On Wed, Jan 28, 2026 at 03:22:13PM -0800, Darrick J. Wong wrote:
> > Unfortunately, this patch causes recursive down_read() of
> > address_space::invalidate_lock.  How was this meant to work?
> 
> Usually the filesystem calls filemap_invalidate_lock{,_shared} if it
> needs to coordinate truncate vs. page removal (i.e. fallocate hole
> punch).  That said, there are a few places where the pagecache itself
> will take that lock too...

> [...]

> ...except that pagecache_ra_unbounded is being called recursively from
> an actual file data read.  My guess is that we'd need a flag or
> something to ask for "unlocked" readahead if we still want readahead to
> spur more readahead.

Basically just move it out of page_cache_ra_unbounded.  With the
consolidation in the earlier patches there are just two callers
of page_cache_ra_unbounded left, this and the redirty_blocks() in f2fs.

I'd kinda wish to kill the latter, as the past-EOF reading is something
that should be restricted to core code, but I can't really think of
an easy way to do that.


  reply	other threads:[~2026-01-30  5:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 15:26 fsverity cleanups, speedup and memory usage optimization v4 Christoph Hellwig
2026-01-28 15:26 ` [PATCH 01/15] fs,fsverity: reject size changes on fsverity files in setattr_prepare Christoph Hellwig
2026-02-17 21:14   ` [f2fs-dev] [PATCH 01/15] fs, fsverity: " patchwork-bot+f2fs
2026-01-28 15:26 ` [PATCH 02/15] fs,fsverity: clear out fsverity_info from common code Christoph Hellwig
2026-01-28 15:26 ` [PATCH 03/15] ext4: don't build the fsverity work handler for !CONFIG_FS_VERITY Christoph Hellwig
2026-01-28 15:26 ` [PATCH 04/15] f2fs: " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 05/15] fsverity: pass struct file to ->write_merkle_tree_block Christoph Hellwig
2026-01-28 15:26 ` [PATCH 06/15] fsverity: start consolidating pagecache code Christoph Hellwig
2026-01-28 15:26 ` [PATCH 07/15] fsverity: don't issue readahead for non-ENOENT errors from __filemap_get_folio Christoph Hellwig
2026-01-28 16:32   ` Darrick J. Wong
2026-01-28 23:48   ` Eric Biggers
2026-01-30  5:48     ` Christoph Hellwig
2026-01-28 15:26 ` [PATCH 08/15] fsverity: kick off hash readahead at data I/O submission time Christoph Hellwig
2026-01-28 16:33   ` Darrick J. Wong
2026-01-28 22:56   ` Eric Biggers
2026-01-28 23:22     ` Darrick J. Wong
2026-01-30  5:55       ` Christoph Hellwig [this message]
2026-01-30  5:51     ` Christoph Hellwig
2026-01-28 15:26 ` [PATCH 09/15] fsverity: deconstify the inode pointer in struct fsverity_info Christoph Hellwig
2026-01-28 15:26 ` [PATCH 10/15] fsverity: push out fsverity_info lookup Christoph Hellwig
2026-01-28 15:26 ` [PATCH 11/15] fs: consolidate fsverity_info lookup in buffer.c Christoph Hellwig
2026-01-28 15:26 ` [PATCH 12/15] ext4: consolidate fsverity_info lookup Christoph Hellwig
2026-01-28 16:28   ` Jan Kara
2026-01-28 15:26 ` [PATCH 13/15] f2fs: " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 14/15] btrfs: " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 15/15] fsverity: use a hashtable to find the fsverity_info Christoph Hellwig
2026-01-29  0:07 ` fsverity cleanups, speedup and memory usage optimization v4 Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260130055541.GC622@lst.de \
    --to=hch@lst.de \
    --cc=aalbersh@redhat.com \
    --cc=brauner@kernel.org \
    --cc=chao@kernel.org \
    --cc=djwong@kernel.org \
    --cc=dsterba@suse.com \
    --cc=ebiggers@kernel.org \
    --cc=fsverity@lists.linux.dev \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox