[PATCH] btrfs: fix error message in btrfs_delete_delayed_dir_index()

[PATCH] btrfs: fix error message in btrfs_delete_delayed_dir_index()

[Mark Harmstone]

Fix the error message in btrfs_delete_delayed_dir_index() if
__btrfs_add_delayed_item() fails: the message says root, inode, index,
error, but we're actually passing index, root, inode, error.

Signed-off-by: Mark Harmstone <mark@harmstone.com>
Fixes: adc1ef55dc04 ("btrfs: add details to error messages at btrfs_delete_delayed_dir_index()")
---
 fs/btrfs/delayed-inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index 1739a0b29c49..2746841c167d 100644
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-inode.c
@@ -1657,7 +1657,7 @@ int btrfs_delete_delayed_dir_index(struct btrfs_trans_handle *trans,
 	if (unlikely(ret)) {
 		btrfs_err(trans->fs_info,
 "failed to add delayed dir index item, root: %llu, inode: %llu, index: %llu, error: %d",
-			  index, btrfs_root_id(node->root), node->inode_id, ret);
+			  btrfs_root_id(node->root), node->inode_id, index, ret);
 		btrfs_delayed_item_release_metadata(dir->root, item);
 		btrfs_release_delayed_item(item);
 	}
-- 
2.52.0

Re: [PATCH] btrfs: fix error message in btrfs_delete_delayed_dir_index()

[Filipe Manana]

On Tue, Feb 17, 2026 at 6:29 PM Mark Harmstone <mark@harmstone.com> wrote:
>
> Fix the error message in btrfs_delete_delayed_dir_index() if
> __btrfs_add_delayed_item() fails: the message says root, inode, index,
> error, but we're actually passing index, root, inode, error.
>
> Signed-off-by: Mark Harmstone <mark@harmstone.com>
> Fixes: adc1ef55dc04 ("btrfs: add details to error messages at btrfs_delete_delayed_dir_index()")

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Pushed it to for-next, thanks.

> ---
>  fs/btrfs/delayed-inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
> index 1739a0b29c49..2746841c167d 100644
> --- a/fs/btrfs/delayed-inode.c
> +++ b/fs/btrfs/delayed-inode.c
> @@ -1657,7 +1657,7 @@ int btrfs_delete_delayed_dir_index(struct btrfs_trans_handle *trans,
>         if (unlikely(ret)) {
>                 btrfs_err(trans->fs_info,
>  "failed to add delayed dir index item, root: %llu, inode: %llu, index: %llu, error: %d",
> -                         index, btrfs_root_id(node->root), node->inode_id, ret);
> +                         btrfs_root_id(node->root), node->inode_id, index, ret);
>                 btrfs_delayed_item_release_metadata(dir->root, item);
>                 btrfs_release_delayed_item(item);
>         }
> --
> 2.52.0
>
>