From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A43A22157B; Sat, 28 Feb 2026 06:42:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772260973; cv=none; b=DD0BsBK/X7ndaBvHidKZBvhs28v6clIjCGFw4qKlw6oAZEkrqCfR2NO3isNrj11c0pvbLJuHWzZnFtEr1SjrjXgob0e35EHTh/ZGJXje4pDjdYYyJ9lvN8JTV5hrwCc/R7V6PGn4/x2wE8j4JUbUjcB0RAMt04jJG1ETYcSQHdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772260973; c=relaxed/simple; bh=RjXh+3ODcjpkGCclxlZLerhUTxAgrS3+Qw6tdSUsizg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QuOxS9guKFDIlOM8yfkdMCyosDarWSmBWAw43uxnCVGJsA59jOGTpbafM/SSfBhyVhUs5/x67/KrKCaj0RVILGRsZUflscWcwliWdUg8Ymvj+N3YNFlqO2HwicRik5iCO2bGT0M1gBspmBXLGRt/Q/4cVL6ML9GaCPoCbGrNTus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YClOM9Wk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YClOM9Wk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32FCCC116D0; Sat, 28 Feb 2026 06:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772260973; bh=RjXh+3ODcjpkGCclxlZLerhUTxAgrS3+Qw6tdSUsizg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YClOM9Wk3/7+pE7QyV7s9mlYuDllppl2YGLrTn0xkJ5pU3h4NtzzqxpXAgzhRI9N2 JuGJGprSvbiCiYCR4+DPFVLVUesA+9zY/ql1wKLu6GOJbDRJOE72dBApORguyRvSk0 Ip+z80iLf2XB3ZIQqPYK3ZEA4iixYi0/FOhgYq24wKd6cZqPgSNMaeZpzPpmIg/H3w 0n7sJMgccYUbEkKSe7BVVGr7K1ToaaAdi9JBbH+YWUnyRyLa4C5j5ZLWu0XZjJO8MA f7GJPwidtEPGlIQhpocckRINXMDZxErl0fKAfQbViWFT5IVTuMqtgP4lHaU8x4cpN/ +BKrl6+TlJfNA== Date: Fri, 27 Feb 2026 22:42:49 -0800 From: Eric Biggers To: Christoph Hellwig Cc: Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 20/25] xor: make xor.ko self-contained in lib/raid/ Message-ID: <20260228064249.GG65277@quark> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-21-hch@lst.de> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226151106.144735-21-hch@lst.de> On Thu, Feb 26, 2026 at 07:10:32AM -0800, Christoph Hellwig wrote: > diff --git a/arch/um/include/asm/xor.h b/lib/raid/xor/um/xor_arch.h > similarity index 61% > rename from arch/um/include/asm/xor.h > rename to lib/raid/xor/um/xor_arch.h > index c9ddedc19301..c75cd9caf792 100644 > --- a/arch/um/include/asm/xor.h > +++ b/lib/raid/xor/um/xor_arch.h > @@ -1,7 +1,4 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > -#ifndef _ASM_UM_XOR_H > -#define _ASM_UM_XOR_H > - > #ifdef CONFIG_64BIT > #undef CONFIG_X86_32 > #else > #define CONFIG_X86_32 1 > #endif Due to this change, the above code that sets CONFIG_X86_32 to the opposite of CONFIG_64BIT is no longer included in xor-sse.c, which uses CONFIG_X86_32. So if the above code actually did anything, this change would have broken it for xor-sse.c. However, based on arch/x86/um/Kconfig, CONFIG_X86_32 is always the opposite of CONFIG_64BIT, so the above code actually has no effect. Does that sound right? - Eric