public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Hongbo Li <lihongbo22@huawei.com>,
	clm@fb.com, dsterba@suse.com, josef@toxicpanda.com, wqu@suse.com
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	lihongbo22@huawei.com, fdmanana@suse.com,
	linux-btrfs@vger.kernel.org, sashal@kernel.org
Subject: Re: [PATCH 6.6 v2] btrfs: free path if inline extents in range_is_hole_in_parent()
Date: Sun, 1 Mar 2026 20:31:58 +0800	[thread overview]
Message-ID: <202603012047.GqC1IRml-lkp@intel.com> (raw)
In-Reply-To: <20260227075219.2594937-1-lihongbo22@huawei.com>

Hi Hongbo,

kernel test robot noticed the following build errors:

[auto build test ERROR on v7.0-rc1]
[also build test ERROR on linus/master next-20260227]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hongbo-Li/btrfs-free-path-if-inline-extents-in-range_is_hole_in_parent/20260227-155544
base:   v7.0-rc1
patch link:    https://lore.kernel.org/r/20260227075219.2594937-1-lihongbo22%40huawei.com
patch subject: [PATCH 6.6 v2] btrfs: free path if inline extents in range_is_hole_in_parent()
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260301/202603012047.GqC1IRml-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260301/202603012047.GqC1IRml-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603012047.GqC1IRml-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/btrfs/send.c:6388:9: error: use of undeclared label 'out'
    6388 |                         goto out;
         |                              ^
   1 error generated.


vim +/out +6388 fs/btrfs/send.c

  6334	
  6335	static int range_is_hole_in_parent(struct send_ctx *sctx,
  6336					   const u64 start,
  6337					   const u64 end)
  6338	{
  6339		BTRFS_PATH_AUTO_FREE(path);
  6340		struct btrfs_key key;
  6341		struct btrfs_root *root = sctx->parent_root;
  6342		u64 search_start = start;
  6343		int ret;
  6344	
  6345		path = alloc_path_for_send();
  6346		if (!path)
  6347			return -ENOMEM;
  6348	
  6349		key.objectid = sctx->cur_ino;
  6350		key.type = BTRFS_EXTENT_DATA_KEY;
  6351		key.offset = search_start;
  6352		ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
  6353		if (ret < 0)
  6354			return ret;
  6355		if (ret > 0 && path->slots[0] > 0)
  6356			path->slots[0]--;
  6357	
  6358		while (search_start < end) {
  6359			struct extent_buffer *leaf = path->nodes[0];
  6360			int slot = path->slots[0];
  6361			struct btrfs_file_extent_item *fi;
  6362			u64 extent_end;
  6363	
  6364			if (slot >= btrfs_header_nritems(leaf)) {
  6365				ret = btrfs_next_leaf(root, path);
  6366				if (ret < 0)
  6367					return ret;
  6368				if (ret > 0)
  6369					break;
  6370				continue;
  6371			}
  6372	
  6373			btrfs_item_key_to_cpu(leaf, &key, slot);
  6374			if (key.objectid < sctx->cur_ino ||
  6375			    key.type < BTRFS_EXTENT_DATA_KEY)
  6376				goto next;
  6377			if (key.objectid > sctx->cur_ino ||
  6378			    key.type > BTRFS_EXTENT_DATA_KEY ||
  6379			    key.offset >= end)
  6380				break;
  6381	
  6382			fi = btrfs_item_ptr(leaf, slot, struct btrfs_file_extent_item);
  6383			extent_end = btrfs_file_extent_end(path);
  6384			if (extent_end <= start)
  6385				goto next;
  6386			if (btrfs_file_extent_type(leaf, fi) == BTRFS_FILE_EXTENT_INLINE) {
  6387				ret = 0;
> 6388				goto out;
  6389			}
  6390			if (btrfs_file_extent_disk_bytenr(leaf, fi) == 0) {
  6391				search_start = extent_end;
  6392				goto next;
  6393			}
  6394			return 0;
  6395	next:
  6396			path->slots[0]++;
  6397		}
  6398		return 1;
  6399	}
  6400	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2026-03-01 12:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27  6:44 [PATCH 6.6] btrfs: free path if inline extents in range_is_hole_in_parent() Hongbo Li
2026-02-27  6:48 ` Qu Wenruo
2026-02-27  6:56   ` Qu Wenruo
2026-02-27  7:16   ` Hongbo Li
2026-02-27  7:20     ` Qu Wenruo
2026-02-27  7:52 ` [PATCH 6.6 v2] " Hongbo Li
2026-02-27  7:54   ` Qu Wenruo
2026-03-01 12:31   ` kernel test robot [this message]
2026-03-01 20:44     ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202603012047.GqC1IRml-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=fdmanana@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=lihongbo22@huawei.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=sashal@kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox