From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: remove the alignment check in end_bbio_data_write()
Date: Wed, 4 Mar 2026 04:20:35 +0100 [thread overview]
Message-ID: <20260304032034.GE8455@twin.jikos.cz> (raw)
In-Reply-To: <51818a7c1233086fe42a3e7a18cf6a144ef14513.1772525669.git.wqu@suse.com>
On Tue, Mar 03, 2026 at 06:45:09PM +1030, Qu Wenruo wrote:
> The check is not necessary because:
>
> - There is already assert_bbio_alignment() at btrfs_submit_bbio()
>
> - There is also btrfs_subpage_assert() for all btrfs_folio_*() helpers
>
> - No similar check in all other endio functions
> No matter if it's data read, compressed read or write.
>
> - There is no such report for very long
> I do not even remember if there is any such report.
Going back in history the first warning was added in 2013 commit
17a5adccf3fd01 ("btrfs: do away with non-whole_page extent I/O") and
then refactored a few times. The changelog says
" I've replaced the whole_page computations with warnings, just to be
sure that we're not issuing partial page reads or writes. The
warnings should probably just go away some time."
I've checked my old logs, no hits and neither on a general web search so
this counts as safe to remove.
next prev parent reply other threads:[~2026-03-04 3:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 8:15 [PATCH 0/2] btrfs: trivial cleanups in end_bbio_data_write() Qu Wenruo
2026-03-03 8:15 ` [PATCH 1/2] btrfs: remove the alignment check " Qu Wenruo
2026-03-04 3:20 ` David Sterba [this message]
2026-03-03 8:15 ` [PATCH 2/2] btrfs: move the mapping_set_error() out of the loop " Qu Wenruo
2026-03-04 3:29 ` [PATCH 0/2] btrfs: trivial cleanups " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304032034.GE8455@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox