From: "Darrick J. Wong" <djwong@kernel.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev,
linux-fsdevel@vger.kernel.org, ebiggers@kernel.org, hch@lst.de,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v4 09/25] iomap: issue readahead for fsverity merkle tree
Date: Mon, 9 Mar 2026 17:57:08 -0700 [thread overview]
Message-ID: <20260310005708.GA6033@frogsfrogsfrogs> (raw)
In-Reply-To: <20260309192355.176980-10-aalbersh@kernel.org>
On Mon, Mar 09, 2026 at 08:23:24PM +0100, Andrey Albershteyn wrote:
> Issue reading of fsverity merkle tree on the fsverity inodes. This way
> metadata will be available at I/O completion time.
>
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
> ---
> fs/iomap/buffered-io.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index a335a18c307f..1d9481f00b41 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -593,6 +593,9 @@ void iomap_read_folio(const struct iomap_ops *ops,
>
> if (iter.pos < i_size_read(iter.inode))
> ctx->vi = fsverity_get_info(iter.inode);
> + if (ctx->vi)
> + fsverity_readahead(ctx->vi, folio->index,
> + folio_nr_pages(folio));
Initiating merkle tree readahead before you start reading in the data
folios? Ok, sounds reasonable, though the old-habits disk-using part
of my brain thinks "should we be allocating the merkle tree *before* the
data blocks?" to improve read bandwidth usage :P
Anyway we can sort through that later so
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
>
> while ((ret = iomap_iter(&iter, ops)) > 0)
> iter.status = iomap_read_folio_iter(&iter, ctx,
> --
> 2.51.2
>
>
next prev parent reply other threads:[~2026-03-10 0:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 19:23 [PATCH v4 00/25] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 01/25] fsverity: report validation errors through fserror to fsnotify Andrey Albershteyn
2026-03-10 0:46 ` Darrick J. Wong
2026-03-11 11:47 ` Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 02/25] fsverity: expose ensure_fsverity_info() Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 03/25] fsverity: generate and store zero-block hash Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 04/25] fsverity: introduce fsverity_folio_zero_hash() Andrey Albershteyn
2026-03-10 0:47 ` Darrick J. Wong
2026-03-09 19:23 ` [PATCH v4 05/25] fsverity: pass digest size and hash of the empty block to ->write Andrey Albershteyn
2026-03-10 0:49 ` Darrick J. Wong
2026-03-09 19:23 ` [PATCH v4 06/25] fsverity: hoist pagecache_read from f2fs/ext4 to fsverity Andrey Albershteyn
2026-03-10 0:49 ` Darrick J. Wong
2026-03-09 19:23 ` [PATCH v4 07/25] iomap: introduce IOMAP_F_FSVERITY and teach writeback to handle fsverity Andrey Albershteyn
2026-03-10 0:54 ` Darrick J. Wong
2026-03-10 8:44 ` Christoph Hellwig
2026-03-09 19:23 ` [PATCH v4 08/25] iomap: obtain fsverity info for read path Andrey Albershteyn
2026-03-10 0:57 ` Darrick J. Wong
2026-03-10 8:44 ` Christoph Hellwig
2026-03-09 19:23 ` [PATCH v4 09/25] iomap: issue readahead for fsverity merkle tree Andrey Albershteyn
2026-03-10 0:57 ` Darrick J. Wong [this message]
2026-03-10 8:45 ` Christoph Hellwig
2026-03-09 19:23 ` [PATCH v4 10/25] iomap: teach iomap to handle fsverity holes and verify data holes Andrey Albershteyn
2026-03-10 1:05 ` Darrick J. Wong
2026-03-10 14:42 ` Andrey Albershteyn
2026-03-10 9:14 ` Christoph Hellwig
2026-03-09 19:23 ` [PATCH v4 11/25] iomap: introduce iomap_fsverity_write() for writing fsverity metadata Andrey Albershteyn
2026-03-10 1:02 ` Darrick J. Wong
2026-03-09 19:23 ` [PATCH v4 12/25] xfs: introduce fsverity on-disk changes Andrey Albershteyn
2026-03-10 1:05 ` Darrick J. Wong
2026-03-09 19:23 ` [PATCH v4 13/25] xfs: initialize fs-verity on file open Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 14/25] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 15/25] xfs: disable direct read path for fs-verity files Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 16/25] xfs: handle fsverity I/O in write/read path Andrey Albershteyn
2026-03-10 1:17 ` Darrick J. Wong
2026-03-09 19:23 ` [PATCH v4 17/25] xfs: use read ioend for fsverity data verification Andrey Albershteyn
2026-03-10 1:21 ` Darrick J. Wong
2026-03-11 11:40 ` Andrey Albershteyn
2026-03-10 9:11 ` Christoph Hellwig
2026-03-09 19:23 ` [PATCH v4 18/25] xfs: add fs-verity support Andrey Albershteyn
2026-03-10 1:26 ` Darrick J. Wong
2026-03-10 15:26 ` Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 19/25] xfs: remove unwritten extents after preallocations in fsverity metadata Andrey Albershteyn
2026-03-10 1:29 ` Darrick J. Wong
2026-03-12 13:50 ` Andrey Albershteyn
2026-03-12 14:52 ` Darrick J. Wong
2026-03-13 11:17 ` Andrey Albershteyn
2026-03-13 14:55 ` Darrick J. Wong
2026-03-09 19:23 ` [PATCH v4 20/25] xfs: add fs-verity ioctls Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 21/25] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 22/25] xfs: check and repair the verity inode flag state Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 23/25] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 24/25] xfs: add fsverity traces Andrey Albershteyn
2026-03-09 19:23 ` [PATCH v4 25/25] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310005708.GA6033@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@kernel.org \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox