Re: [PATCH v2 0/2] btrfs: enhance BTRFS_ORDERED_* flags sanity checks

[David Sterba <dsterba@suse.cz>]

On Sat, Mar 14, 2026 at 10:30:37AM +1030, Qu Wenruo wrote:
> [CHANGELOG]
> v2:
> - Minor grammar fixes
> - Change the output message when overlapping OEs are found
> - Use has_single_bit_set() to replace hweight*()
> 
> 
> During my development of introduce a new DELAYED type, I incorrectly
> called something like:
> 
> 	oe = alloc_ordered_extent(.., BTRFS_ORDERED_DELAYED, ..);
> 
> That doesn't trigger any warning at runtime, but will cause unexpected
> bugs due to the fact that, BTRFS_ORDERED_* can not be directly used as a
> flag. They are only bit numbers, thus should be utilized with bit
> operations like "test_bit(BTRFS_ORDERED_DELAYED, ..)".
> 
> My stupid bug inspired me to enhance the @flags sanity checks in
> alloc_ordered_extent().
> 
> The first one is to make sure that my stupid bug can always be caught
> early.
> 
> The second one is to enhance the error message when a duplicated OE is
> found during insert_ordered_extent().
> 
> Qu Wenruo (2):
>   btrfs: check type flags in alloc_ordered_extent()
>   btrfs: output more info when duplicated ordered extent is found

Reviewed-by: David Sterba <dsterba@suse.com>