From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F4FE3E9F62; Thu, 19 Mar 2026 17:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939823; cv=none; b=G3TuM3+22iFg6lfoU2KJNQmfFmvSP5tJ85ywHFVYo5uh3H3WRFJ+95BZhZvyfcakPGM1KMaw6f/3s80VIjb4IDrlcaYvEbJDscajkHR+6IHCdJT+8W1+L5KUTKxO0ss4fnkz64JB4kgSJrxqwLfh+XgUgawl6e3+PvzqfymQXu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939823; c=relaxed/simple; bh=iRVMo4LLqzTvxVAS9W3KUEqySn3JSIcTykHsq1FaLnQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S459PxmyZF5DEnPX0FxzWiIMNRRz9WQYV4Nn/PfHZA7R+b3wP+eUqJisiLOjHjuDKKNLDXRWQdjJcSj8YYFFW4nWgM0dVQ+AvC7Ct/HRH98wfVnXtycLdxA41EH0QhBPg3enXma5/v2S9bxw2o4dEriAAsb+z+wkdlsXRzzzQXo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mQMRHckj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mQMRHckj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24D16C19424; Thu, 19 Mar 2026 17:03:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773939823; bh=iRVMo4LLqzTvxVAS9W3KUEqySn3JSIcTykHsq1FaLnQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mQMRHckjLAdVsZaqX/qjHghOSxgfL4XlvMvXCBM8cVKeKSLxU6EobRp9JbWI5RjKP l0/OoKiOjN2Pa5Ia9qGulcHnTr4jQGVqBIxzKdDsdR5QGWI75uRtTQK9oWO6QLzDBF 8iyw0vJvo36Vj3WUNQZBxJXGdeiHOx33FG5MTPvUdDT+1DFKyQXs4g76pobAqul5dC 6b8frew9vHq6t3YkbxJrMvX7oNMT/mqAqigtxEfzj5RFjGtP/jOqcYVeB9omMFB4b3 CiqalbBymP1ZUD7N/8VsxT9gUXMWLsitWakaISenfyF0YvK/R50SYvVQnMqVQctu/F kzyFX5v4bcdug== From: Andrey Albershteyn To: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org, ebiggers@kernel.org Cc: Andrey Albershteyn , hch@lst.de, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, djwong@kernel.org Subject: [PATCH v5 24/25] xfs: add fsverity traces Date: Thu, 19 Mar 2026 18:02:11 +0100 Message-ID: <20260319170231.1455553-25-aalbersh@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260319170231.1455553-1-aalbersh@kernel.org> References: <20260319170231.1455553-1-aalbersh@kernel.org> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Even though fsverity has traces, debugging issues with varying block sizes could be a bit less transparent without read/write traces. Signed-off-by: Andrey Albershteyn Reviewed-by: "Darrick J. Wong" --- fs/xfs/xfs_fsverity.c | 6 ++++++ fs/xfs/xfs_trace.h | 46 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+) diff --git a/fs/xfs/xfs_fsverity.c b/fs/xfs/xfs_fsverity.c index ecc66ee8bac5..6db8113da52f 100644 --- a/fs/xfs/xfs_fsverity.c +++ b/fs/xfs/xfs_fsverity.c @@ -64,6 +64,8 @@ xfs_fsverity_get_descriptor( uint32_t blocksize = i_blocksize(VFS_I(ip)); xfs_fileoff_t last_block_offset; + trace_xfs_fsverity_get_descriptor(ip); + ASSERT(inode->i_flags & S_VERITY); error = xfs_bmap_last_extent(NULL, ip, XFS_DATA_FORK, &rec, &is_empty); if (error) @@ -377,6 +379,7 @@ xfs_fsverity_read_merkle( pgoff_t index) { index += xfs_fsverity_metadata_offset(XFS_I(inode)) >> PAGE_SHIFT; + trace_xfs_fsverity_read_merkle(XFS_I(inode), index, PAGE_SIZE); return generic_read_merkle_tree_page(inode, index); } @@ -391,6 +394,7 @@ xfs_fsverity_readahead_merkle_tree( unsigned long nr_pages) { index += xfs_fsverity_metadata_offset(XFS_I(inode)) >> PAGE_SHIFT; + trace_xfs_fsverity_read_merkle(XFS_I(inode), index, PAGE_SIZE); generic_readahead_merkle_tree(inode, index, nr_pages); } @@ -414,6 +418,8 @@ xfs_fsverity_write_merkle( const char *p; unsigned int i; + trace_xfs_fsverity_write_merkle(XFS_I(inode), position, size); + if (position + size > inode->i_sb->s_maxbytes) return -EFBIG; diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 813e5a9f57eb..d37f3096c03e 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -6419,6 +6419,52 @@ TRACE_EVENT(xfs_verify_media_error, __entry->error) ); +TRACE_EVENT(xfs_fsverity_get_descriptor, + TP_PROTO(struct xfs_inode *ip), + TP_ARGS(ip), + TP_STRUCT__entry( + __field(dev_t, dev) + __field(xfs_ino_t, ino) + ), + TP_fast_assign( + __entry->dev = VFS_I(ip)->i_sb->s_dev; + __entry->ino = ip->i_ino; + ), + TP_printk("dev %d:%d ino 0x%llx", + MAJOR(__entry->dev), MINOR(__entry->dev), + __entry->ino) +); + +DECLARE_EVENT_CLASS(xfs_fsverity_class, + TP_PROTO(struct xfs_inode *ip, u64 pos, size_t length), + TP_ARGS(ip, pos, length), + TP_STRUCT__entry( + __field(dev_t, dev) + __field(xfs_ino_t, ino) + __field(u64, pos) + __field(size_t, length) + ), + TP_fast_assign( + __entry->dev = VFS_I(ip)->i_sb->s_dev; + __entry->ino = ip->i_ino; + __entry->pos = pos; + __entry->length = length; + ), + TP_printk("dev %d:%d ino 0x%llx pos 0x%llx length 0x%zx", + MAJOR(__entry->dev), MINOR(__entry->dev), + __entry->ino, + __entry->pos, + __entry->length) +) + +#define DEFINE_FSVERITY_EVENT(name) \ +DEFINE_EVENT(xfs_fsverity_class, name, \ + TP_PROTO(struct xfs_inode *ip, u64 pos, size_t length), \ + TP_ARGS(ip, pos, length)) +DEFINE_FSVERITY_EVENT(xfs_fsverity_read_merkle); +DEFINE_FSVERITY_EVENT(xfs_fsverity_write_merkle); +DEFINE_FSVERITY_EVENT(xfs_fsverity_file_corrupt); + #endif /* _TRACE_XFS_H */ #undef TRACE_INCLUDE_PATH -- 2.51.2