From: David Sterba <dsterba@suse.cz>
To: "JP Kobryn (Meta)" <jp.kobryn@linux.dev>
Cc: boris@bur.io, mark@harmstone.com, clm@fb.com, wqu@suse.com,
dsterba@suse.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-team@meta.com
Subject: Re: [PATCH 1/2] btrfs: additional gfp api for allocating compressed folios
Date: Fri, 20 Mar 2026 18:55:26 +0100 [thread overview]
Message-ID: <20260320175526.GF5735@twin.jikos.cz> (raw)
In-Reply-To: <20260320073445.80218-2-jp.kobryn@linux.dev>
On Fri, Mar 20, 2026 at 12:34:44AM -0700, JP Kobryn (Meta) wrote:
> btrfs_alloc_compr_folio() assumes all callers want GFP_NOFS. This is fine
> for most cases, however there are some call sites that would benefit from
> different flags. One such case is preventing direct reclaim from occurring
> during readahead allocations. With unbounded reclaim during this time,
> noticeable latency will occur under high memory pressure.
>
> Provide an additional API that accepts one additional gfp_t parameter,
> giving callers flexibility over the characteristics of their allocation.
If you still need to set the gfp flags in v2, please drop this patch and
extend btrfs_alloc_compr_folio(), the API is internal and we don't need
it fine grained.
next prev parent reply other threads:[~2026-03-20 17:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 7:34 [PATCH 0/2] btrfs: prevent direct reclaim during compressed readahead JP Kobryn (Meta)
2026-03-20 7:34 ` [PATCH 1/2] btrfs: additional gfp api for allocating compressed folios JP Kobryn (Meta)
2026-03-20 11:11 ` Mark Harmstone
2026-03-20 17:55 ` David Sterba [this message]
2026-03-20 7:34 ` [PATCH 2/2] btrfs: prevent direct reclaim during compressed readahead JP Kobryn (Meta)
2026-03-20 7:36 ` Christoph Hellwig
2026-03-20 16:17 ` JP Kobryn (Meta)
2026-03-20 10:12 ` Qu Wenruo
2026-03-20 11:14 ` Mark Harmstone
2026-03-20 11:11 ` Mark Harmstone
2026-03-20 11:10 ` [PATCH 0/2] " Mark Harmstone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320175526.GF5735@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=boris@bur.io \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jp.kobryn@linux.dev \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-team@meta.com \
--cc=mark@harmstone.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox