Re: [PATCH] btrfs: fix unnecessary UUID tree rescan on mount

[Dave Chen <davechen@synology.com>]

On Thu, Apr 2, 2026 at 4:00 PM Filipe Manana <fdmanana@kernel.org> wrote:
>
> > Fixes: 70f80175472 ("Btrfs: check UUID tree during mount if required")
>
> Normally we only use the Fixes tag for functional bugs and performance
> regressions that cause usability problems.
>
> How much slowdown did you see because of the unnecessary rescan?
> For this to make any significant difference we would probably need
> several thousand subvolumes or snapshots.

You're right, I don't have benchmark numbers from a filesystem with
thousands of subvolumes to quantify the impact. I'll drop the Fixes
tag and resend a v2 as a correctness improvement.

> The change looks good to me; however, thanks.
>
> Reviewed-by: Filipe Manana <fdmanana@suse.com>

Thanks for the review, I'll carry your Reviewed-by tag in v2.

Dave

Disclaimer: The contents of this e-mail message and any attachments are confidential and are intended solely for addressee. The information may also be legally privileged. This transmission is sent in trust, for the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mail or phone and delete this message and its attachments, if any.