Re: [PATCH] btrfs: make more ASSERTs verbose, part 3

[David Sterba <dsterba@suse.cz>]

On Wed, Apr 01, 2026 at 03:24:39PM +0100, Filipe Manana wrote:
> > @@ -2335,7 +2338,8 @@ static int btrfs_insert_replace_extent(struct btrfs_trans_handle *trans,
> >                             btrfs_item_ptr_offset(leaf, slot),
> >                             sizeof(struct btrfs_file_extent_item));
> >         extent = btrfs_item_ptr(leaf, slot, struct btrfs_file_extent_item);
> > -       ASSERT(btrfs_file_extent_type(leaf, extent) != BTRFS_FILE_EXTENT_INLINE);
> > +       ASSERT(btrfs_file_extent_type(leaf, extent) != BTRFS_FILE_EXTENT_INLINE,
> > +              "file_extent_type=%u", btrfs_file_extent_type(leaf, extent));
> 
> There's no point printing the file extent type here, if the assertion
> fails it's because it's an inline extent. This would only be useful if
> we were asserting it's inline, not that it's not inline.

Right, I was skipping the pattern where it was clear why the assertion
failed but missed that one.