From: David Sterba <dsterba@suse.cz>
To: Boris Burkov <boris@bur.io>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v4 3/4] btrfs: make inode->outstanding_extents a u64
Date: Mon, 13 Apr 2026 20:43:03 +0200 [thread overview]
Message-ID: <20260413184303.GE12792@twin.jikos.cz> (raw)
In-Reply-To: <fab916144bcfc974c3231ac9dbd57e28faa02a28.1775756790.git.boris@bur.io>
On Thu, Apr 09, 2026 at 10:48:50AM -0700, Boris Burkov wrote:
> - inode->outstanding_extents += mod;
> + ASSERT(mod == 1 || mod == -1, "mod=%d", mod);
> + ASSERT(nr_extents <= S64_MAX, "nr_extents=%llu", nr_extents);
> + ASSERT(mod == -1 || inode->outstanding_extents <= U64_MAX - nr_extents,
> + "nr_extents=%llu, inode->outstanding_extents=%llu",
Small note, please don't put "," between the key=values, it's just
stylistic but to keep it consistent with the rest of the ASSERTs.
Thanks.
next prev parent reply other threads:[~2026-04-13 18:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 17:48 [PATCH v4 0/4] btrfs: improve stalls under sudden writeback Boris Burkov
2026-04-09 17:48 ` [PATCH v4 1/4] btrfs: reserve space for delayed_refs in delalloc Boris Burkov
2026-04-10 16:07 ` Filipe Manana
2026-04-09 17:48 ` [PATCH v4 2/4] btrfs: account for compression in delalloc extent reservation Boris Burkov
2026-04-09 17:48 ` [PATCH v4 3/4] btrfs: make inode->outstanding_extents a u64 Boris Burkov
2026-04-13 18:43 ` David Sterba [this message]
2026-04-09 17:48 ` [PATCH v4 4/4] btrfs: cap shrink_delalloc iterations to 128M Boris Burkov
2026-04-13 18:41 ` [PATCH v4 0/4] btrfs: improve stalls under sudden writeback David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413184303.GE12792@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=boris@bur.io \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox