Re: [PATCH v2 1/2] btrfs: remove the COW fixup mechanism

[David Sterba <dsterba@suse.cz>]

On Tue, Apr 14, 2026 at 10:46:41AM +0930, Qu Wenruo wrote:
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -1739,12 +1739,6 @@ static noinline_for_stack int extent_writepage_io(struct btrfs_inode *inode,
>  	       start, len, folio_start, folio_size(folio));
>  
>  	ret = btrfs_writepage_cow_fixup(folio);

The btrfs_writepage_cow_fixup() is left to do the check but now the name
does not match what it's doing, it basically verifies the ordered bit is
set or return EUCLEAN.

Either here or in a separate patch please rename it, to something like
"verify ordered" or something describing what we expect here so we can
forget about what 'fixup' meant.

> -	if (ret == -EAGAIN) {
> -		/* Fixup worker will requeue */
> -		folio_redirty_for_writepage(bio_ctrl->wbc, folio);
> -		folio_unlock(folio);
> -		return 1;
> -	}
>  	if (ret < 0) {
>  		btrfs_folio_clear_dirty(fs_info, folio, start, len);
>  		btrfs_folio_set_writeback(fs_info, folio, start, len);