From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: use min_size variable to setup block rsv in btrfs_replace_file_extents()
Date: Tue, 21 Apr 2026 05:14:23 +0200 [thread overview]
Message-ID: <20260421031423.GC12792@twin.jikos.cz> (raw)
In-Reply-To: <efc156002e21e5453d58c2c0856f605575f27642.1776693213.git.fdmanana@suse.com>
On Mon, Apr 20, 2026 at 02:53:56PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> There's no need to calculate again the size for the temporary block
> reserve in btrfs_replace_file_extents() - we have already calculated it
> and stored it in the 'min_size' variable.
>
> So use the variable to make it more clear and also make the variable const
> since it's not supposed to change during the whole function.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2026-04-21 3:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 13:53 [PATCH] btrfs: use min_size variable to setup block rsv in btrfs_replace_file_extents() fdmanana
2026-04-20 21:57 ` Qu Wenruo
2026-04-21 3:14 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421031423.GC12792@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox