From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: collapse report_eb_range() into its single caller
Date: Fri, 24 Apr 2026 04:38:35 +0200 [thread overview]
Message-ID: <20260424023835.GA3542906@twin.jikos.cz> (raw)
In-Reply-To: <b2dc0f485fc063e2b666e150002f59a278b97023.1776944252.git.fdmanana@suse.com>
On Thu, Apr 23, 2026 at 12:38:13PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> There's no point in having this static function since it's too short and
> it has a single caller (check_eb_range()), so move its code into the
> caller and remove it.
The point is to separate the check and report functionality, so the
check part is inline and a simple if (a few instructions), while the
report is not always inlined and is considered cold code.
next prev parent reply other threads:[~2026-04-24 2:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 11:38 [PATCH] btrfs: collapse report_eb_range() into its single caller fdmanana
2026-04-23 14:54 ` Johannes Thumshirn
2026-04-23 21:43 ` Qu Wenruo
2026-04-24 2:38 ` David Sterba [this message]
2026-04-24 3:11 ` David Sterba
2026-04-24 15:20 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424023835.GA3542906@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox