Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFC 4/5] btrfs: remove 2K block size support
Date: Fri, 24 Apr 2026 12:13:45 +0200	[thread overview]
Message-ID: <20260424101345.GA3906171@twin.jikos.cz> (raw)
In-Reply-To: <0673de432dd2e64c8d32671247710aab33f7254d.1777019132.git.wqu@suse.com>

On Fri, Apr 24, 2026 at 06:21:33PM +0930, Qu Wenruo wrote:
> Originally 2K block size support was introduced to test subpage (block
> size < page size) on x86_64 where the page size is exactly the original
> minimal block size.
> 
> However that 2K block size support has some problems:
> 
> - No 2K nodesize support
>   This is critical, as there is still no way to exercise the subpage
>   metadata routine.
> 
> - Very easy to test subpage data path now
>   With the currently experimental large folio support, it's very easy to
>   test the subpage data folio path already, as when a folio larger than
>   4K is encountered on x86_64, we will need all the subpage folio states
>   and bitmaps.
> 
>   So there is no need to use 2K block size just to verify subpage data
>   path even on x86_64.
> 
> And with the incoming huge folio (2M on x86_64) support, the 2K block
> size will easily double the bitmap size, considering the burden to
> maintain and the limited extra coverage, I believe it's time to remove
> it for the incoming huge folio support.

Ok then, the 2K support is inferior compared to the folio updates so off
it goes. You can add it now so you don't have to keep it in the series.

  reply	other threads:[~2026-04-24 10:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24  8:51 [PATCH RFC 0/5] btrfs: support huge data folios for 4K page size Qu Wenruo
2026-04-24  8:51 ` [PATCH RFC 1/5] btrfs: update the out-of-date comments on subpage Qu Wenruo
2026-04-24  8:51 ` [PATCH RFC 2/5] btrfs: prepare subpage operations to support >= BITS_PER_LONG sub-bitmaps Qu Wenruo
2026-04-24  8:51 ` [PATCH RFC 3/5] btrfs: migrate btrfs_bio_ctrl::submit_bitmap to support larger bitmaps Qu Wenruo
2026-04-24  8:51 ` [PATCH RFC 4/5] btrfs: remove 2K block size support Qu Wenruo
2026-04-24 10:13   ` David Sterba [this message]
2026-04-24  8:51 ` [PATCH RFC 5/5] btrfs: introduce support for huge folios Qu Wenruo
2026-04-27 14:10 ` [PATCH RFC 0/5] btrfs: support huge data folios for 4K page size David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260424101345.GA3906171@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox