From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: enable cross-folio readahead for bs < ps and large folio cases
Date: Tue, 28 Apr 2026 05:53:02 +0200 [thread overview]
Message-ID: <20260428035302.GE3906171@suse.cz> (raw)
In-Reply-To: <af83ea95-fcf2-4405-9d63-2f4e70296105@gmx.com>
On Tue, Apr 28, 2026 at 07:24:00AM +0930, Qu Wenruo wrote:
>
>
> 在 2026/4/27 22:51, David Sterba 写道:
> > On Sun, Apr 26, 2026 at 05:21:03PM +0930, Qu Wenruo wrote:
> >> --- a/fs/btrfs/compression.c
> >> +++ b/fs/btrfs/compression.c
> >> @@ -358,10 +358,7 @@ struct compressed_bio *btrfs_alloc_compressed_write(struct btrfs_inode *inode,
> >> * Add extra pages in the same compressed file extent so that we don't need to
> >> * re-read the same extent again and again.
> >> *
> >> - * NOTE: this won't work well for subpage, as for subpage read, we lock the
> >> - * full page then submit bio for each compressed/regular extents.
> >> - *
> >> - * This means, if we have several sectors in the same page points to the same
> >> + * If we have several sectors in the same page points to the same
> >
> > The sentence seems to be missing some words, or I don't understand
> > what's the meaning here.
>
> This means the situation like the following:
>
> | Folio range |
> | Ext A| | Ext B|
>
> Where Ext A and B are backed by the same compressed extent.
>
> In that case, if we're reading Ext A, the readahead won't work for Ext B.
Ok, so it should read "If we have several sectors inthe same page
that points to the same ...".
next prev parent reply other threads:[~2026-04-28 3:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 7:51 [PATCH 0/2] btrfs: properly enable compressed readahead for bs < ps and large folio cases Qu Wenruo
2026-04-26 7:51 ` [PATCH 1/2] btrfs: enable cross-folio " Qu Wenruo
2026-04-27 13:21 ` David Sterba
2026-04-27 21:54 ` Qu Wenruo
2026-04-28 3:53 ` David Sterba [this message]
2026-04-26 7:51 ` [PATCH 2/2] btrfs: refresh add_ra_bio_pages() to indicate it's using folios Qu Wenruo
2026-04-27 13:37 ` David Sterba
2026-04-27 13:38 ` [PATCH 0/2] btrfs: properly enable compressed readahead for bs < ps and large folio cases David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428035302.GE3906171@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox