From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2F8E3C2777 for ; Fri, 15 May 2026 14:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778856725; cv=none; b=Tm+1DBe3bbvyKwiupwq1cSYiKxzpjKztuzVsUB9gi0BLSFNfTDOjP03mvHWMtpsJJVB41JiTYesdXxeyL39eQB0xCGIAmwjdfOEZfvuLTD91RyrcCUDnjj+iEXmMMLuqdE5+7EPU8I1J289m0h2bv3wmfD4dMD2lch6CjBHikNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778856725; c=relaxed/simple; bh=/+b/V5bDHHWru7Bz5kIaZTKrsXrjFN3haRDJFBMCoeU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TYs2T/Rbay7xLNpmnISU76LQXbNSbNxZrlP+fyr1Puz0B/OgGwyuwQRVGXvAIxF3cbrQ334L1iqrIShA1ZXJ2VWvia7nm1o3sHteRLe0dkTResoQGjCLmnuG2rmPMp1E8YoN+LYeUgo7PenzsQybxsyH0gVMn553sR9pzh5hNpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4B04666D5C; Fri, 15 May 2026 14:52:00 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 041E0593A9; Fri, 15 May 2026 14:52:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BdG/ABAzB2onPgAAD6G6ig (envelope-from ); Fri, 15 May 2026 14:52:00 +0000 Date: Fri, 15 May 2026 16:51:58 +0200 From: David Sterba To: "H. Peter Anvin" Cc: kreijack@inwind.it, Goffredo Baroncelli , Christoph Hellwig , Andrew Morton , Catalin Marinas , Will Deacon , Ard Biesheuvel , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 01/19] btrfs: require at least 4 devices for RAID 6 Message-ID: <20260515145158.GP2558453@suse.cz> Reply-To: dsterba@suse.cz References: <20260512052230.2947683-1-hch@lst.de> <20260512052230.2947683-2-hch@lst.de> <20260512114231.GG2558453@suse.cz> <20260513054742.GA1018@lst.de> <0a8d1ff4-f5a2-49e9-aa45-d25dbe4ded40@libero.it> <0507CCEF-0548-442F-8703-1D006B5E068B@zytor.com> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0507CCEF-0548-442F-8703-1D006B5E068B@zytor.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 4B04666D5C X-Spam-Score: -4.00 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Level: On Thu, May 14, 2026 at 12:57:53PM -0700, H. Peter Anvin wrote: > On May 14, 2026 12:51:59 PM PDT, Goffredo Baroncelli wrote: > >On 13/05/2026 07.47, Christoph Hellwig wrote: > >> On Tue, May 12, 2026 at 01:42:31PM +0200, David Sterba wrote: > > > >> > >>> The degenerate modes of > >>> raid0, 5, or 6 are explicit as a possible middle step when converting > >>> profiles. We can use a fallback implementation for this case if the > >>> accelerated implementations cannot do it. > >> > >> This is not about a degenerated mode. For a degenerated RAID 6, parity > >> generation uses the RAID 5 XOR routines as the second parity will be > >> missing. This is about generating two parities for a single data disk, > >> which must be explicitly selected. > >> > > > >I think that the David concern is : "what happens for an already > >existing btrfs raid6 3 disks filesystem when the user upgrade the kernel ?" > >(I am thinking when a new BG needs to be allocated)... > > That's what I'm saying – it should invoke the RAID-1 code under the cover (as with 3 disks, D = P = Q.) Thanks, it was not clear to me what you meant. For the two edge cases the code should do simple memcpy for both calculations of parity and recovery.