From: David Sterba <dsterba@suse.cz>
To: Matthew Wilcox <willy@infradead.org>
Cc: Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, Qu Wenruo <wqu@suse.com>,
Boris Burkov <boris@bur.io>, Filipe Manana <fdmanana@suse.com>,
Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Subject: Re: [PATCH 0/3] Three folio-related btrfs fixes
Date: Sat, 23 May 2026 16:06:01 +0200 [thread overview]
Message-ID: <20260523140601.GA183694@suse.cz> (raw)
In-Reply-To: <ahDtLYinnFX5CBcE@casper.infradead.org>
On Sat, May 23, 2026 at 12:56:29AM +0100, Matthew Wilcox wrote:
> On Sat, May 23, 2026 at 12:38:55AM +0200, David Sterba wrote:
> > On Fri, May 22, 2026 at 07:14:06PM +0100, Matthew Wilcox (Oracle) wrote:
> > > All of these were discovered through auditing the (mis)uses of the folio
> > > API throughout the kernel; I haven't been specifically reviewing btrfs,
> > > nor testing.
> > >
> > > Matthew Wilcox (Oracle) (3):
> > > Revert "btrfs: fix the file offset calculation inside
> > > btrfs_decompress_buf2page()"
> >
> > Why do you do the revert? It does not seem suitable for this case, we
> > use reverts if we want to get back to the original behaviour, or when
> > removing a patch from a long series to avoid a rebase. Merging the first
> > and second patch makes more sense to me.
>
> The revert is for a patch which was merged into v6.16. Since the fix
> for page_offset() was merged into v6.15, af566bdaff54 should never have
> been merged, and it can safely be reverted.
That it can be safely/cleanly reverted does not matter, you could say
that about many other patches. If the code was wrong then fix it in a
"forward" manner, no need for revert, namely for code from a year ago.
next prev parent reply other threads:[~2026-05-23 14:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 18:14 [PATCH 0/3] Three folio-related btrfs fixes Matthew Wilcox (Oracle)
2026-05-22 18:14 ` [PATCH 1/3] Revert "btrfs: fix the file offset calculation inside btrfs_decompress_buf2page()" Matthew Wilcox (Oracle)
2026-05-22 18:14 ` [PATCH 2/3] btrfs: Use folio_put() Matthew Wilcox (Oracle)
2026-05-22 21:15 ` Boris Burkov
2026-05-22 18:14 ` [PATCH 3/3] btrfs: Remove use of bv_page Matthew Wilcox (Oracle)
2026-05-22 21:20 ` [PATCH 0/3] Three folio-related btrfs fixes Boris Burkov
2026-05-22 21:57 ` Qu Wenruo
2026-05-22 22:07 ` Boris Burkov
2026-05-22 21:47 ` Qu Wenruo
2026-05-22 22:38 ` David Sterba
2026-05-22 23:56 ` Matthew Wilcox
2026-05-23 14:06 ` David Sterba [this message]
2026-05-24 20:05 ` Matthew Wilcox
2026-05-24 23:16 ` Qu Wenruo
2026-05-25 10:28 ` David Sterba
2026-05-25 12:02 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260523140601.GA183694@suse.cz \
--to=dsterba@suse.cz \
--cc=boris@bur.io \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fdmanana@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sweettea-kernel@dorminy.me \
--cc=willy@infradead.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox