Re: [PATCH 19/28] btrfs: tracepoints: add trace event for add_conflicting_inode()

[David Sterba <dsterba@suse.cz>]

On Sat, May 23, 2026 at 06:57:32PM +0100, Filipe Manana wrote:
> On Sat, May 23, 2026 at 6:51 PM David Sterba <dsterba@suse.cz> wrote:
> >
> > On Fri, May 15, 2026 at 06:00:16PM +0100, fdmanana@kernel.org wrote:
> > > From: Filipe Manana <fdmanana@suse.com>
> > > +     TP_fast_assign(
> > > +             TP_fast_assign_fsid(trans->fs_info);
> > > +             __entry->root_objectid          = btrfs_root_id(ctx->inode->root);
> > > +             __entry->transid                = trans->transid;
> > > +             __entry->ctx_ino                = btrfs_ino(ctx->inode);
> > > +             __entry->conflict_ino           = ino;
> > > +             __entry->conflict_ino_parent    = parent;
> > > +     ),
> > > +
> > > +     TP_printk_btrfs("root=%llu(%s) transid=%llu ctx_ino=%llu conflic_ino=%llu"
> >                                                                  ^^^^^^^^^^^
> >
> > This looks like a typo, "conflict_ino" as the variable names.
> >
> > > +                     " conflict_ino_parent=%llu",
> > > +                     show_root_type(__entry->root_objectid), __entry->transid,
> > > +                     __entry->ctx_ino, __entry->conflict_ino,
> > > +                     __entry->conflict_ino_parent)
> > > +);
> > > +
> > > +TRACE_EVENT(btrfs_add_conflicting_inode_exit,
> > ...
> > > +     TP_printk_btrfs("root=%llu(%s) transid=%llu ctx_ino=%llu conflic_ino=%llu"
> >
> > And here.
> >
> > Otherwise no other typos spotted in the whole series and the formats
> > look consistent. I'll fix the two in for-next. Thanks.
> 
> No it's not a typo. It's intentional to call it conflict_ino - as ino

conflic_ino ... with missing 't', or did you reall mean to write 'conflic'?