From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86A4434252D; Mon, 31 Aug 2026 18:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788202013; cv=none; b=pYs+EBDtsKy+Fiu1cntTp5TD77H9kv1f/0a5tHPN4V36BUVrmymZQUeszTadVCG+aCJkf0lbsNjy7XevN/AEx6UG81TNzS3ArLMoKvS0BlVPdUhT+2Clt5Jq0DWTsWmPRqfyHjxrqqqaGcYawAA3vwcHFYY7LyVzMrKdutj1W9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788202013; c=relaxed/simple; bh=hERYWHHGfn9suJoaeQoBi5VMCdjQasSBnMKoRFnrzmI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K9VffGjQPL8usugJ6GcHcR3l2jYLx1rRDFrWcC96q78Rwbx0O0ZIaJagXibwBRdSJ+sU7eYgqjpSZO+6O+BMkhh5ObcqZM6h4FwYvRJvZsGRZtymhw+VhTA8U6NYNNpE+W99fQsn8ZRIyW6O8KwJ4inTt8292orsSLXDTulDSr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=EgqhIPcq; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=nC7rEa1U; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=YBeAtZKL; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=juclcREm; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="EgqhIPcq"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="nC7rEa1U"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="YBeAtZKL"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="juclcREm" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 191091FB39; Mon, 31 Aug 2026 18:46:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1788202005; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=adPvtYMwlgxXQ7Oro16VusI6wUrO/bduGmk63+FTmQ4=; b=EgqhIPcqIK8FOzqYEOSSv9p+T1HfHj5DIjT4niyvTAAnTF8nQlWNP2iGHHzjAW5UobtSUv QizLi6KssgDUVVr7DdgSeUkY347Sn7153mdnh10gj34iRa19Q7iE1QA/km9861Ap9DT/qa tmo3Juclu3TtmOwiAOBLx4Nl1Y228PY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1788202005; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=adPvtYMwlgxXQ7Oro16VusI6wUrO/bduGmk63+FTmQ4=; b=nC7rEa1UZn0b9zKsR6rgGO2TYjJqzecwwlroyp6adoTDGLc+dlcGmG2zz0iEzfce7I+X42 SzDZc8CkkL+CF1Dw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1788202001; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=adPvtYMwlgxXQ7Oro16VusI6wUrO/bduGmk63+FTmQ4=; b=YBeAtZKLYr8NtYYPfHWJQUldf93VyDOEumoXoW+ykPuYyMRlTNdEO5OAd7fXBCeo3l0tON JJgOmRZk1kNYLcTzsSCRpqSy1sqtOhgLMOOG0pCMJXWQkao0iQIQBbfY2kt1ZTRAk+Z68T e5dyDE4gTMRnq49DY18WARNKfUtgO3E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1788202001; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=adPvtYMwlgxXQ7Oro16VusI6wUrO/bduGmk63+FTmQ4=; b=juclcREmfFICsNOJD/esOOaytQBVFtbNrNCbkyV6xizRTEyDrKjjM3op70xyF/5n3qpasZ Rhv6ZjYDoYaEMlCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B4E9913515; Mon, 31 Aug 2026 18:46:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id RfE2KxDMlWridQAAD6G6ig (envelope-from ); Mon, 31 Aug 2026 18:46:40 +0000 Date: Mon, 31 Aug 2026 20:46:31 +0200 From: David Sterba To: David Gow Cc: Jim Cromie , "Maciej W . Rozycki" , Andrew Morton , Matthew Auld , Arun Pravin , Joel Fernandes , David Airlie , Simona Vetter , Chris Mason , David Sterba , dri-devel@lists.freedesktop.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] fs:btrfs: Use the new global is_power_of_2_u64() helper Message-ID: <20260831184631.GI9053@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20260830103321.2042968-1-david@davidgow.net> <20260830103321.2042968-3-david@davidgow.net> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260830103321.2042968-3-david@davidgow.net> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Level: X-Spam-Score: -2.50 X-Spam-Flag: NO X-Spamd-Result: default: False [-2.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; HAS_REPLYTO(0.30)[dsterba@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,orcam.me.uk,linux-foundation.org,intel.com,amd.com,nvidia.com,ffwll.ch,kernel.org,suse.com,lists.freedesktop.org,vger.kernel.org]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email,davidgow.net:email,suse.cz:replyto,twin.jikos.cz:mid,imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; REPLYTO_DOM_NEQ_TO_DOM(0.00)[] On Sun, Aug 30, 2026 at 06:33:17PM +0800, David Gow wrote: > btrfs currently provides its own 64-bit safe version of > is_power_of_2(), in order to handle 64-bit values on 32-bit systems. > > Since other subsystems also have similar helpers, a new implementation > has been added to linux/log2.h. Use this instead of the btrfs-specific > one. > > Signed-off-by: David Gow > --- > > This basically just replaces a btrfs helper with the version in patch 1. > It probably doesn't make sense for this series to go in via the btrfs > tree, so it's probably worth either accepting the posssibility for a > conflict, or sending this patch in separately after the first one lands. Acked-by: David Sterba As this is library API cleanup, feel free to take it with the rest of the series.