From: David Sterba <dsterba@suse.cz>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Anand Suveer Jain <asj@kernel.org>,
dsterba@suse.cz, linux-btrfs@vger.kernel.org,
thiago.macieira@intel.com, dave.hansen@intel.com
Subject: Re: [PATCH] btrfs: derive f_fsid with dev_t only when temp_fsid is active
Date: Mon, 14 Sep 2026 18:41:48 +0200 [thread overview]
Message-ID: <20260914164148.GM54722@twin.jikos.cz> (raw)
In-Reply-To: <f130860f8e12c46688a7fcc158f3f34fa042e47e.camel@infradead.org>
On Mon, Sep 14, 2026 at 12:47:53PM +0200, David Woodhouse wrote:
> On Mon, 2026-09-14 at 16:28 +0800, Anand Suveer Jain wrote:
> >
> >
> > > > . For stable kernels, this flag will keep the new f_fsid derivation
> > > > disabled by default.
> >
> >
> > > No. That still gives you a broken fsid on upgrading to the next major kernel, doesn't it?
> >
> > Upgrading to a _major_ kernel would require an extra step to re-encrypt
> > with the new FSID _for some configs_.
> > A one-time operational overhead.
>
> I'm not keen on that. The documentation is fairly poor, but historical
> behaviour and expectation is that the FSID is supposed to be *stable*.
> You're not supposed to randomly change it from one kernel to the next.
That's what I consider sane and would like to preserve. We allow users
to change the UUID by tools, but this means the user is aware of that
and initiating such action.
> Won't this also trigger some incremental backup schemes to re-archive
> every file as it seems the {fsid, ino} has changed?
This is a good point, I don't know if backup tools do that but it's
quite natual thing to do.
next prev parent reply other threads:[~2026-09-14 16:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 18:06 [PATCH] btrfs: derive f_fsid with dev_t only when temp_fsid is active Anand Jain
2026-09-12 21:58 ` Dave Hansen
2026-09-13 1:05 ` Anand Suveer Jain
2026-09-13 1:13 ` Dave Hansen
2026-09-13 2:43 ` Anand Suveer Jain
2026-09-14 3:42 ` Anand Suveer Jain
2026-09-14 5:28 ` David Woodhouse
2026-09-14 8:28 ` Anand Suveer Jain
2026-09-14 10:47 ` David Woodhouse
2026-09-14 12:28 ` Anand Suveer Jain
2026-09-14 16:41 ` David Sterba [this message]
2026-09-14 16:39 ` David Sterba
2026-09-14 16:46 ` David Sterba
2026-09-18 8:59 ` Anand Suveer Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914164148.GM54722@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=asj@kernel.org \
--cc=dave.hansen@intel.com \
--cc=dwmw2@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=thiago.macieira@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox