Re: [PATCH] btrfs: cleanup submit_extent_folio()

[Boris Burkov <boris@bur.io>]

On Sun, Sep 13, 2026 at 08:59:15PM +0930, Qu Wenruo wrote:
> Cleanup submit_extent_folio() by:
> 
> - Remove @size parameter
>   Since commit b2e743927fdd ("btrfs: make btrfs_do_readpage() to do
>   block-by-block read"), all callers are passing sectorsize as @size,
>   so there is no need for such parameter.
> 
>   Furthermore since we only write one block at a time, there is no need
>   for a while() loop, nor the advance of various local variables.
> 
> - Update the comments on the parameter list
>   * @disk_bytenr is shared for both read and write
>   * rename @page to @folio
> 
> - Update the return value to return 0 or error
>   Since we won't queue multiple blocks anyway, there is no point in
>   returning the queued bytes.
>   It makes more sense to return an error code, although the only error
>   code will be -EUCLEAN for writes.
> 
> - Rename submit_extent_folio() to submit_one_block()
> 
> - Rename submit_one_sector() to submit_write_sector()
> 
> - Update the error message to utilize the new returned error code inside
>   submit_write_sector()
> 
Reviewed-by: Boris Burkov <boris@bur.io>
> Signed-off-by: Qu Wenruo <wqu@suse.com>