Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Boris Burkov <boris@bur.io>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/2] btrfs: introduce more accurate usebackuproot options
Date: Wed, 30 Sep 2026 11:23:25 -0700	[thread overview]
Message-ID: <20260930182325.GA3186434@zen.localdomain> (raw)
In-Reply-To: <9c907c139ede11a4b3026bd15b310de034690bc6.1788678078.git.wqu@suse.com>

On Sun, Sep 06, 2026 at 04:33:38PM +0930, Qu Wenruo wrote:
> Previously we had no way to tell btrfs to use which backup slot, but
> always use the newest backup, and retry until all backup roots are
> exhausted.
> 
> This doesn't give any control to the end user, even if the end user
> wants to use a specific backup slot.
> 
> To address this problem, allow more fine-control on usebackuproot rescue
> option by introducing the following 4 rescue mount options:
> 
> - rescue=usebackuproot_0
> - rescue=usebackuproot_1
> - rescue=usebackuproot_2
> - rescue=usebackuproot_3

What do you think about mirroring the compression levels and having the
option parse as rescue=usebackuproot[:N] rather than 4 options?

> 
> The number 0 means the newest slot, which should be the same as the one
> recorded in the super block and no need to load any backup root.
> 
> 1/2/3 means the second/third/fourth(oldest) backup slot to use.
> 
> The existing "rescue=usebackuproot" is just an alias of
> "rescue=usebackuproot_1".
> 
> This will allow users to choose which backup root to use, thus can have
> a better control than blindly choose any slot that can pass the very
> basic root node checks.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>
 

  reply	other threads:[~2026-09-30 18:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-06  7:03 [PATCH v2 0/2] btrfs: allow more fine control to rescue=usebackuproot Qu Wenruo
2026-09-06  7:03 ` [PATCH v2 1/2] btrfs: always use the second newest slot for rescue=usebackuproot Qu Wenruo
2026-09-30 18:29   ` Boris Burkov
2026-09-06  7:03 ` [PATCH v2 2/2] btrfs: introduce more accurate usebackuproot options Qu Wenruo
2026-09-30 18:23   ` Boris Burkov [this message]
2026-09-30 21:41     ` Qu Wenruo
2026-09-30 18:30 ` [PATCH v2 0/2] btrfs: allow more fine control to rescue=usebackuproot Boris Burkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930182325.GA3186434@zen.localdomain \
    --to=boris@bur.io \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox