Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Cheng Yongkang <teel4res@gmail.com>
To: Qu Wenruo <wqu@suse.com>
Cc: David Sterba <dsterba@suse.com>, Chris Mason <mason@kernel.org>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] btrfs: tree-checker: reject file extents with oversized disk_num_bytes
Date: Mon, 16 Nov 2026 20:57:24 -0800	[thread overview]
Message-ID: <20261117045725.606165-1-teel4res@gmail.com> (raw)
In-Reply-To: <35bcaa47-55c5-4b2f-962a-c3168bdf52a5@suse.com>

On 2026/11/17 15:01, Qu Wenruo wrote:
> I don't know which agent you're using, but I have seen several ones (not
> only from you) doing this linking-to-older-versions behavior.
>
> It doesn't make much sense.
[...]
> And the full changelog would make more sense, other than letting the
> reviewer to jump to your previous version for history.

The links came from Documentation/process/submitting-patches.rst, which
recommends adding lore links to previous versions after the "---" line.
Its example also lists the changes of every version, though, and I only
listed the v3 changes. That was my mistake.

I'll follow the btrfs style from now on: the full changelog of all
versions, without links to the older ones.

> I think the ram bytes check should apply to both compressed and
> uncompressed extents.
>
> For compressed, it's MAX_UNCOMPRESSED, and for uncompressed it's U32_MAX.

Will do in v4, with max_ram_bytes picked the same way as
max_disk_num_bytes.

Thanks,
Cheng Yongkang

  reply	other threads:[~2026-11-17  4:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  2:38 [PATCH v3] btrfs: tree-checker: reject file extents with oversized disk_num_bytes Cheng Yongkang
2026-11-17  4:31 ` Qu Wenruo
2026-11-17  4:57   ` Cheng Yongkang [this message]
2026-11-17  5:38     ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117045725.606165-1-teel4res@gmail.com \
    --to=teel4res@gmail.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox