From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Josef Bacik <jbacik@fb.com>
Cc: clm@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH V20 04/19] Btrfs: subpage-blocksize: Define extent_buffer_head
Date: Wed, 27 Jul 2016 20:19:49 +0530 [thread overview]
Message-ID: <2038528.NqA4dD0tmx@localhost.localdomain> (raw)
In-Reply-To: <99c633e7-38b8-3147-aca8-3be34dd32295@fb.com>
On Tuesday, July 26, 2016 01:42:08 PM Josef Bacik wrote:
> On 07/04/2016 12:34 AM, Chandan Rajendra wrote:
> > In order to handle multiple extent buffers per page, first we need to create a
> > way to handle all the extent buffers that are attached to a page.
> >
> > This patch creates a new data structure 'struct extent_buffer_head', and moves
> > fields that are common to all extent buffers from 'struct extent_buffer' to
> > 'struct extent_buffer_head'
> >
> > Also, this patch moves EXTENT_BUFFER_TREE_REF, EXTENT_BUFFER_DUMMY and
> > EXTENT_BUFFER_IN_TREE flags from extent_buffer->ebflags to
> > extent_buffer_head->bflags.
> >
> > Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
> > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>
> I'm sorry Chandan I'm still having problems with this one. XFS kmalloc()'s its
> sub pagesize ranges for it's metadata buffers, how about we do that instead of
> doing the extent_buffer_head. Look at xfs_buf_allocate_memory() for what I'm
> thinking. Thanks,
>
Ok. I will look into the xfs metadata buffer allocation code. Thanks for the
guidance.
--
chandan
next prev parent reply other threads:[~2016-07-27 14:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 4:34 [PATCH V20 00/19] Allow I/O on blocks whose size is less than page size Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 01/19] Btrfs: subpage-blocksize: Fix whole page read Chandan Rajendra
2016-07-26 16:11 ` Josef Bacik
2016-07-27 10:15 ` Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 02/19] Btrfs: subpage-blocksize: Fix whole page write Chandan Rajendra
2016-07-26 17:18 ` Josef Bacik
2016-07-04 4:34 ` [PATCH V20 03/19] Btrfs: subpage-blocksize: Make sure delalloc range intersects with the locked page's range Chandan Rajendra
2016-07-26 17:19 ` Josef Bacik
2016-07-04 4:34 ` [PATCH V20 04/19] Btrfs: subpage-blocksize: Define extent_buffer_head Chandan Rajendra
2016-07-26 17:42 ` Josef Bacik
2016-07-27 14:49 ` Chandan Rajendra [this message]
2016-07-04 4:34 ` [PATCH V20 05/19] Btrfs: subpage-blocksize: Read tree blocks whose size is < PAGE_SIZE Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 06/19] Btrfs: subpage-blocksize: Write only dirty extent buffers belonging to a page Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 07/19] Btrfs: subpage-blocksize: Allow mounting filesystems where sectorsize < PAGE_SIZE Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 08/19] Btrfs: subpage-blocksize: Deal with partial ordered extent allocations Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 09/19] Btrfs: subpage-blocksize: Explicitly track I/O status of blocks of an ordered extent Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 10/19] Btrfs: subpage-blocksize: btrfs_punch_hole: Fix uptodate blocks check Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 11/19] Btrfs: subpage-blocksize: Prevent writes to an extent buffer when PG_writeback flag is set Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 12/19] Revert "btrfs: fix lockups from btrfs_clear_path_blocking" Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 13/19] Btrfs: subpage-blocksize: Fix file defragmentation code Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 14/19] Btrfs: subpage-blocksize: Enable dedupe ioctl Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 15/19] Btrfs: subpage-blocksize: btrfs_clone: Flush dirty blocks of a page that do not map the clone range Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 16/19] Btrfs: subpage-blocksize: Make file extent relocate code subpage blocksize aware Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 17/19] Btrfs: subpage-blocksize: __btrfs_lookup_bio_sums: Set offset when moving to a new bio_vec Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 18/19] Btrfs: subpage-blocksize: Disable compression Chandan Rajendra
2016-07-04 4:34 ` [PATCH V20 19/19] Btrfs: subpage-blocksize: Rate limit scrub error message Chandan Rajendra
2016-07-12 16:06 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2038528.NqA4dD0tmx@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).