From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] btrfs: use variable for io_tree when clearing range in btrfs_page_mkwrite()
Date: Wed, 9 Jul 2025 19:32:40 +0930 [thread overview]
Message-ID: <20489128-ca79-48be-9b43-dc125dfb9659@gmx.com> (raw)
In-Reply-To: <a8b95fa1119a5cff19ccde53ffc182d2441c1172.1752050704.git.fdmanana@suse.com>
在 2025/7/9 18:23, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> We have the inode's io_tree already stored in a local variable, so use it
> instead of grabbing it again in the call to btrfs_clear_extent_bit().
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
> index f08c72dbb530..e76e92873de5 100644
> --- a/fs/btrfs/file.c
> +++ b/fs/btrfs/file.c
> @@ -1940,7 +1940,7 @@ static vm_fault_t btrfs_page_mkwrite(struct vm_fault *vmf)
> * clear any delalloc bits within this page range since we have to
> * reserve data&meta space before lock_page() (see above comments).
> */
> - btrfs_clear_extent_bit(&BTRFS_I(inode)->io_tree, page_start, end,
> + btrfs_clear_extent_bit(io_tree, page_start, end,
> EXTENT_DELALLOC | EXTENT_DO_ACCOUNTING |
> EXTENT_DEFRAG, &cached_state);
>
next prev parent reply other threads:[~2025-07-09 10:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 8:53 [PATCH 0/3] btrfs: fix mmap writes for NOCOW files/extents fdmanana
2025-07-09 8:53 ` [PATCH 1/3] btrfs: fix -ENOSPC mmap write failure on " fdmanana
2025-07-09 10:02 ` Qu Wenruo
2025-07-09 10:36 ` Filipe Manana
2025-07-09 8:53 ` [PATCH 2/3] btrfs: use variable for io_tree when clearing range in btrfs_page_mkwrite() fdmanana
2025-07-09 10:02 ` Qu Wenruo [this message]
2025-07-09 8:53 ` [PATCH 3/3] btrfs: use btrfs_inode local variable at btrfs_page_mkwrite() fdmanana
2025-07-09 10:04 ` Qu Wenruo
2025-07-09 10:39 ` Filipe Manana
2025-07-09 11:13 ` [PATCH v2 0/3] btrfs: fix mmap writes for NOCOW files/extents fdmanana
2025-07-09 11:13 ` [PATCH v2 1/3] btrfs: fix -ENOSPC mmap write failure on " fdmanana
2025-07-09 11:13 ` [PATCH v2 2/3] btrfs: use variable for io_tree when clearing range in btrfs_page_mkwrite() fdmanana
2025-07-09 11:13 ` [PATCH v2 3/3] btrfs: use btrfs_inode local variable at btrfs_page_mkwrite() fdmanana
2025-07-09 11:45 ` [PATCH v3 0/3] btrfs: fix mmap writes for NOCOW files/extents fdmanana
2025-07-09 11:45 ` [PATCH v3 1/3] btrfs: fix -ENOSPC mmap write failure on " fdmanana
2025-07-09 11:45 ` [PATCH v3 2/3] btrfs: use variable for io_tree when clearing range in btrfs_page_mkwrite() fdmanana
2025-07-09 11:45 ` [PATCH v3 3/3] btrfs: use btrfs_inode local variable at btrfs_page_mkwrite() fdmanana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20489128-ca79-48be-9b43-dc125dfb9659@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox