From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
chandan@mykolab.com
Subject: Re: [PATCH V2] _btrfs_stress_subvolume: Fix race condition by making 'subvolume stress' task to exit gracefully
Date: Mon, 21 Mar 2016 19:27:49 +0530 [thread overview]
Message-ID: <2067159.W4Pk9hPgLa@localhost.localdomain> (raw)
In-Reply-To: <20160321120706.GE11419@eguan.usersys.redhat.com>
On Monday 21 Mar 2016 20:07:06 Eryu Guan wrote:
> > diff --git a/common/rc b/common/rc
> > index 16f5a43..7d971ea 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -3280,9 +3280,10 @@ _btrfs_stress_subvolume()
> >
> > local btrfs_mnt=$2
> > local subvol_name=$3
> > local subvol_mnt=$4
> >
> > + local stop_file=$stop_file
>
> This should be "local stop_file=$5"
>
> Otherwise looks good to me, at least there's no regression, all affected
> tests still pass for me and no other tests fail because of unclean exit
> from previous test.
>
> Reviewed-by: Eryu Guan <eguan@redhat.com>
Sorry, I will fix it and send V3.
--
chandan
prev parent reply other threads:[~2016-03-21 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 7:39 [PATCH V2] _btrfs_stress_subvolume: Fix race condition by making 'subvolume stress' task to exit gracefully Chandan Rajendra
2016-03-21 12:07 ` Eryu Guan
2016-03-21 13:57 ` Chandan Rajendra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2067159.W4Pk9hPgLa@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=chandan@mykolab.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).