Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: waxhead <waxhead@dirtcellar.net>
To: linux-btrfs@vger.kernel.org
Subject: Why do we need these mount options?
Date: Thu, 14 Jan 2021 03:12:26 +0100	[thread overview]
Message-ID: <208dba68-b47e-101d-c893-8173df8fbbbf@dirtcellar.net> (raw)

Howdy,

I was looking through the mount options and being a madman with strong 
opinions I can't help thinking that a lot of them does not really belong 
as mount options at all, but should rather be properties set on the 
subvolume - for example the toplevel subvolume.

And any options set on a child subvolume should override the parrent 
subvolume the way I see it.

By having a quick look - I don't see why these should be mount options 
at all.

autodefrag / noautodefrag
commit
compress / compress-force
datacow / nodatacow
datasum / nodatasum
discard / nodiscard
inode_cache / noinode_cache
space_cache / nospace_cache
sdd / ssd_spread / nossd / no_ssdspread
user_subvol_rm_allowed

Stuff like compress and nodatacow can be set with chattr so there is as 
far as I am aware three methods of setting compression for example.

Either by mount options in fstab, by chattr or by btrfs property set

I think it would be more consistent to have one interface for adjusting 
behavior.

As I asked before, the future plan to have different storage profiles on 
subvolumes seem to have been sneakily(?) removed from the wiki - if that 
is indeed a dropped goal I can see why it makes sense to keep the mount 
options, if not I think the mount options should go in favor of btrfs 
property set.

             reply	other threads:[~2021-01-14  2:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14  2:12 waxhead [this message]
2021-01-14 16:37 ` Why do we need these mount options? David Sterba
2021-01-15  0:02   ` waxhead
2021-01-15 15:29     ` David Sterba
2021-01-16  1:47       ` waxhead
2021-01-15  3:54   ` Zygo Blaxell
2021-01-15  9:32     ` waxhead
2021-01-16  0:42       ` Zygo Blaxell
2021-01-16  1:57         ` waxhead
2021-01-16  3:51           ` Zygo Blaxell
2021-01-16  7:39     ` Andrei Borzenkov
2021-01-16 15:19       ` Adam Borowski
2021-01-16 17:21         ` Andrei Borzenkov
2021-01-16 20:01           ` Zygo Blaxell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=208dba68-b47e-101d-c893-8173df8fbbbf@dirtcellar.net \
    --to=waxhead@dirtcellar.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox