From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
Anatoly Pugachev <matorola@gmail.com>
Subject: Re: [PATCH v2 0/6] Btrfs: free space tree and sanity test fixes
Date: Wed, 28 Sep 2016 18:33:16 +0530 [thread overview]
Message-ID: <2118496.9cv27FvD1a@localhost.localdomain> (raw)
In-Reply-To: <cover.1474580472.git.osandov@fb.com>
On Thursday, September 22, 2016 05:22:31 PM Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> This is v2 of my earlier series "Btrfs: fix free space tree
> bitmaps+tests on big-endian systems" [1]. Patches 1, 4, and 5 are the
> same as patches 1, 2, and 3 from the original series. I've added patch 2
> to fix another bug I noticed (an xfstest went out earlier). Patch 3 is
> the result of the earlier discussion here [2]. Finally, patch 6 was
> necessary to get the sanity tests to run on my MIPS emulator.
>
> This series applies to v4.8-rc7. The sanity tests pass on both x86-64
> and MIPS, and there are no xfstests regressions. Chandan and Anatoly,
> could you test these out as well?
Hello Omar,
I have executed xfstests on a big endian ppc64 guest with 'MOUNT_OPTIONS="-o
space_cache=v2"' config option. I have also executed generic/127 on a
filesystem created using "fragment-free-space-tree.py" that you had provided
sometime ago. I did not notice any regressions during the test runs.
Tested-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>
> I'm working on the btrfs-progs follow up, but these patches are safe
> without that -- the new FREE_SPACE_TREE_VALID bit will stop all versions
> of btrfs-progs from mounting read-write.
>
> Thanks!
>
> 1: http://marc.info/?l=linux-btrfs&m=146853909905570&w=2
> 2: http://marc.info/?l=linux-btrfs&m=147448992301110&w=2
>
> Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> Cc: Anatoly Pugachev <matorola@gmail.com>
>
> Omar Sandoval (6):
> Btrfs: fix free space tree bitmaps on big-endian systems
> Btrfs: fix mount -o clear_cache,space_cache=v2
> Btrfs: catch invalid free space trees
> Btrfs: fix extent buffer bitmap tests on big-endian systems
> Btrfs: expand free space tree sanity tests to catch endianness bug
> Btrfs: use less memory for delalloc sanity tests
>
> fs/btrfs/ctree.h | 3 +-
> fs/btrfs/disk-io.c | 33 ++++---
> fs/btrfs/extent_io.c | 64 +++++++++----
> fs/btrfs/extent_io.h | 22 +++++
> fs/btrfs/free-space-tree.c | 19 ++--
> fs/btrfs/tests/extent-io-tests.c | 95 +++++++++++--------
> fs/btrfs/tests/free-space-tree-tests.c | 164 +++++++++++++++++++--------------
> include/uapi/linux/btrfs.h | 10 +-
> 8 files changed, 261 insertions(+), 149 deletions(-)
>
>
--
chandan
prev parent reply other threads:[~2016-09-28 13:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 0:22 [PATCH v2 0/6] Btrfs: free space tree and sanity test fixes Omar Sandoval
2016-09-23 0:24 ` [PATCH v2 1/6] Btrfs: fix free space tree bitmaps on big-endian systems Omar Sandoval
2016-09-23 14:37 ` Holger Hoffstätte
2016-09-23 0:24 ` [PATCH v2 2/6] Btrfs: fix mount -o clear_cache,space_cache=v2 Omar Sandoval
2016-09-23 14:37 ` Holger Hoffstätte
2016-09-23 0:24 ` [PATCH v2 3/6] Btrfs: catch invalid free space trees Omar Sandoval
2016-09-23 14:40 ` Holger Hoffstätte
2016-09-24 19:50 ` Hans van Kranenburg
2016-09-26 17:39 ` Omar Sandoval
2016-09-26 17:46 ` Hans van Kranenburg
2016-09-26 17:52 ` Omar Sandoval
2016-09-26 23:13 ` Omar Sandoval
2016-09-29 11:43 ` David Sterba
2016-09-23 0:24 ` [PATCH v2 4/6] Btrfs: fix extent buffer bitmap tests on big-endian systems Omar Sandoval
2016-09-23 0:24 ` [PATCH v2 5/6] Btrfs: expand free space tree sanity tests to catch endianness bug Omar Sandoval
2016-09-23 0:24 ` [PATCH v2 6/6] Btrfs: use less memory for delalloc sanity tests Omar Sandoval
2016-09-23 9:27 ` David Sterba
2016-09-23 16:52 ` Omar Sandoval
2016-09-23 21:22 ` Omar Sandoval
2016-09-26 15:58 ` David Sterba
2016-09-26 17:33 ` Omar Sandoval
2016-09-25 7:55 ` [PATCH v2 0/6] Btrfs: free space tree and sanity test fixes Anatoly Pugachev
2016-09-26 17:50 ` David Sterba
2016-09-26 17:56 ` Omar Sandoval
2016-09-29 12:21 ` Anatoly Pugachev
2016-09-29 12:52 ` Holger Hoffstätte
2016-09-29 13:02 ` Anatoly Pugachev
2016-09-29 14:29 ` David Sterba
2016-10-01 9:26 ` Anatoly Pugachev
2016-09-26 17:51 ` Omar Sandoval
2016-09-28 13:03 ` Chandan Rajendra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2118496.9cv27FvD1a@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=matorola@gmail.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).