From: Anand Jain <anand.jain@oracle.com>
To: Su Yue <l@damenly.su>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 1/2] btrfs: prevent NULL pointer dereference in extent_io_tree_panic()
Date: Mon, 4 Jan 2021 15:33:06 +0800 [thread overview]
Message-ID: <21bc38aa-87be-7ec2-3ef6-06df790ed4b8@oracle.com> (raw)
In-Reply-To: <20210103092804.756-2-l@damenly.su>
On 3/1/21 5:28 pm, Su Yue wrote:
> Some extent io trees are initialized with NULL private member(e.g., btrfs_devi
> ce::alloc_state and btrfs_fs_info::excluded_extents). Dereference of a NULL
> @tree->private as struct inode * will cause kernel panic.
>
> Just pass @tree->fs_info as parameter to extent_io_tree_panic() directly.
> Let it panic as expected at least.
>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Thanks.
> Fixes: 05912a3c04eb ("btrfs: drop extent_io_ops::tree_fs_info callback")
> Signed-off-by: Su Yue <l@damenly.su>
next prev parent reply other threads:[~2021-01-04 7:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 9:28 [PATCH v2 0/2] btrfs: fix issues when mouting the poc image Su Yue
2021-01-03 9:28 ` [PATCH v2 1/2] btrfs: prevent NULL pointer dereference in extent_io_tree_panic() Su Yue
2021-01-04 7:33 ` Anand Jain [this message]
2021-01-03 9:28 ` [PATCH v2 2/2] btrfs: tree-checker: check if chunk item end oveflows Su Yue
2021-01-04 8:31 ` Anand Jain
2021-01-04 9:15 ` Su Yue
2021-01-05 3:31 ` Anand Jain
2021-01-04 15:59 ` David Sterba
2021-01-04 15:58 ` [PATCH v2 0/2] btrfs: fix issues when mouting the poc image David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21bc38aa-87be-7ec2-3ef6-06df790ed4b8@oracle.com \
--to=anand.jain@oracle.com \
--cc=l@damenly.su \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox