Re: [PATCH v2 1/2] btrfs: Implement DRW lock

[Nikolay Borisov <nborisov@suse.com>]

On 30.01.20 г. 16:06 ч., David Sterba wrote:
> On Thu, Jan 30, 2020 at 03:37:26PM +0200, Nikolay Borisov wrote:
>>> +int btrfs_drw_lock_init(struct btrfs_drw_lock *lock)
>>> +{
>>> +	int ret;
>>> +
>>> +	ret = percpu_counter_init(&lock->writers, 0, GFP_KERNEL);
>>> +	if (ret)
>>> +		return ret;
>>> +
>>> +	atomic_set(&lock->readers, 0);
>>> +	init_waitqueue_head(&lock->pending_readers);
>>> +	init_waitqueue_head(&lock->pending_writers);
>>> +
>>> +	return 0;
>>> +}
>>> +EXPORT_SYMBOL(btrfs_drw_lock_init);
>>
>> I have the functions EXPORT_SYMBOL since I have an internal patch which
>> is hooking this code to locktorture. SO they can be removed.
> 
> You can make the exports conditional, #ifdef LOCKTORTURE.
> 

I don't think I will be submitting that patch  unless the lock is moved
to lib/. I guess I will just remove it in v3 after review.