From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>,
linux-btrfs@vger.kernel.org, kilobyte@angband.pl,
demfloro@demfloro.ru
Subject: Re: [PATCH v3 0/7] Chunk level degradable check
Date: Thu, 9 Mar 2017 02:31:55 +0800 [thread overview]
Message-ID: <22a333f7-27e7-2491-88c2-cae0ac2c32fa@oracle.com> (raw)
In-Reply-To: <20170308024124.16899-1-quwenruo@cn.fujitsu.com>
> v3:
> Remove one duplicated missing device output
> Use the advice from Anand Jain, not to add new members in btrfs_device,
> but use a new structure extra_rw_degrade_errors, to record error when
> sending down/waiting device.
Suggested local variables because, v2 had theoretical bug as assessed
before. The actual fix (while the variables continue to be at struct
device) may not be in the scope of this patch, as the btrfs as such
would not handle the intermittent device disappear/reappear as of now.
So though I believe in the long term the barrier failure should be part
of per device dev_stat rather, but at the moment to keep the original
design as it is in the scope of this patch a local stack variable will
suffice.
Hope this clarifies better.
Thanks, Anand
next prev parent reply other threads:[~2017-03-08 18:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 2:41 [PATCH v3 0/7] Chunk level degradable check Qu Wenruo
2017-03-08 2:41 ` [PATCH v3 1/7] btrfs: Introduce a function to check if all chunks a OK for degraded rw mount Qu Wenruo
2017-03-08 2:41 ` [PATCH v3 2/7] btrfs: Do chunk level rw degrade check at mount time Qu Wenruo
2017-03-08 2:41 ` [PATCH v3 3/7] btrfs: Do chunk level degradation check for remount Qu Wenruo
2017-03-08 2:41 ` [PATCH v3 4/7] btrfs: Introduce extra_rw_degrade_errors parameter for btrfs_check_rw_degradable Qu Wenruo
2017-03-08 2:41 ` [PATCH v3 5/7] btrfs: Allow barrier_all_devices to do chunk level device check Qu Wenruo
2017-03-08 2:41 ` [PATCH v3 6/7] btrfs: Cleanup num_tolerated_disk_barrier_failures Qu Wenruo
2017-03-08 2:41 ` [PATCH v3 7/7] btrfs: Enhance missing device kernel message Qu Wenruo
2017-03-08 5:26 ` Andrei Borzenkov
2017-03-08 5:43 ` Qu Wenruo
2017-03-08 6:47 ` [PATCH v3 0/7] Chunk level degradable check Adam Borowski
2017-03-08 7:39 ` Qu Wenruo
2017-03-08 18:40 ` Anand Jain
2017-03-08 19:01 ` Anand Jain
2017-03-08 8:00 ` Dmitrii Tcvetkov
2017-03-08 12:25 ` Austin S. Hemmelgarn
2017-03-08 18:31 ` Anand Jain [this message]
2017-03-08 21:08 ` Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22a333f7-27e7-2491-88c2-cae0ac2c32fa@oracle.com \
--to=anand.jain@oracle.com \
--cc=demfloro@demfloro.ru \
--cc=kilobyte@angband.pl \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).