From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v7 0/2] btrfs: Introduce new rescue= mount options
Date: Fri, 5 Jun 2020 17:22:16 +0800 [thread overview]
Message-ID: <236d8772-2e55-bdb1-339c-655f69510234@oracle.com> (raw)
In-Reply-To: <20200604071807.61345-1-wqu@suse.com>
On 4/6/20 3:18 pm, Qu Wenruo wrote:
> There are quite a lot btrfs extent tree corruption report in the mail
> list.
> Since btrfs will do mount time block group item search, one corrupted
> leaf containing block group item will prevent the whole fs to be
> mounted.
>
Can you add btrfs_info/warn() at those places to indicate
-o rescue=skip.. might help to mount in RO.
> This patchset will try to address the problem by introducing a new mount
> option, "rescue=skipbg", as a last-resort rescue.
Do you think there might be another check to skip during mount at some
point. So if why not add a generic -o rescue=skipchecks? Of course
dmesg -k must show what has been skipped.
> This "rescue=skipbg" has some advantage compared to user space tool
> like "btrfs-restore":
> - Unified recovery tool
Yes.
Thanks, Anand
prev parent reply other threads:[~2020-06-05 9:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 7:18 [PATCH v7 0/2] btrfs: Introduce new rescue= mount options Qu Wenruo
2020-06-04 7:18 ` [PATCH v7 1/2] btrfs: Introduce "rescue=" mount option Qu Wenruo
2020-06-04 13:15 ` Josef Bacik
2020-06-05 10:04 ` Anand Jain
2020-06-05 11:36 ` David Sterba
2020-06-08 8:11 ` Anand Jain
2020-06-08 9:39 ` Qu Wenruo
2020-06-10 14:47 ` David Sterba
2020-06-10 15:11 ` David Sterba
2020-06-04 7:18 ` [PATCH v7 2/2] btrfs: Introduce new mount option to skip block group items scan Qu Wenruo
2020-06-04 13:17 ` Josef Bacik
2020-06-05 10:03 ` Anand Jain
2020-06-05 9:22 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=236d8772-2e55-bdb1-339c-655f69510234@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox