From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4648F3806A6 for ; Tue, 19 May 2026 06:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779171314; cv=none; b=oWdYYRzd9+t71rquCiBWhvgXJ2K76WNc1rg7GAo1WmTS3GHYtQiENtzJbZQpyEW2OtPj0TL9dKgfCrw5LcnW9cHX46Cr3zivhVQKjnm90fY5sQlJ27wd+KUq7HCEQg3PFlzgGMM4yQPQpXjhXhNUGWiJxVfeI5+Qrxo4yx/EHw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779171314; c=relaxed/simple; bh=mm7k25tlmn4xkTO8xL313/O6AZxpv3Ovc4fBIijl5iE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HbGc3sW+/qbVmMhk+5LzeAvQu1pr7XNx5os6LKcFgTD6wbqK+E4gjUncnK4akAxFGFX0rstoiWtj6RKPvIga6GR/XdB3OCJ4gOh3jiBIHyAsMdcyptvdOYM54KKcmm6mghZmuHvYc58xcd6xCHo581i7N/+nLP1wodza7iqmlqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s3UJIkHv; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s3UJIkHv" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-3680540a6efso1601273a91.2 for ; Mon, 18 May 2026 23:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779171313; x=1779776113; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RsnCMoFb4eb7A398idYgiUXDd+PPPCKn8DaQJvFslBc=; b=s3UJIkHvAFnjKtNi3oxoWd3jN3pZ+u7/XVIWxWfNvFloxfXozZL+whyrc29SP0W0VU lunHfD+A2yzBpk6lE57LsBJ7ZJBh6OsFp81VIeDBo1gs3CCRU0XjtT9NYL4zb/Kr1wg1 vcQtH+9yrdkEvg3R3AfcdQoJbYYsU3mm3s7bziBBNHpm0rpb3alLW2LNOypJA8tbZ3DW U8VSV2LJC6Y2YSaFyAschl+dfgfpO4l+pT6O08a/Shve8zSqQZqqmJ8UZNOpejsXp742 FtbJypALcR020lV7ncTqt4I5nZhisJpfHoWXkwqzpMeBrbdb+HRz4+dKgAWsED99yTd/ yjIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779171313; x=1779776113; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RsnCMoFb4eb7A398idYgiUXDd+PPPCKn8DaQJvFslBc=; b=M8ndsXUnjsGISaq489C9JOfjjzxuBDLNiStjLOgsm+rXmf6bfq//I4Fn7AWVQlZMA4 39sQvkq6ESzs4nEDK7XDUDTg/0kkB18CLubfWvSCm5In209CP20ldW7NNLTUGkjPqfND n+DN4eHFar3BfEb4e91suS6BCTP18e+GF8WOYN+zclTli7/keLQtDfSKJSPe00DqiTEv fs7R8yHfU3a6oOhJ2qmYDoYCNt21Vz9stFrd5EzsN6ZjHbq63Fmtj5IAWkAceZ//zE+F +28DejFLPGmn/ZLYEk7jXEhnhMbvz/CU6hZMrqZE7B4k3LlT+5FM/NxoNZRW0S3lDRE6 0mEg== X-Gm-Message-State: AOJu0Yy05IUMrkwkFpYDOWRoXpZWnmIf5K9A+yF9v7H1GF7xfSXhNn3s LYdV9a+rHaN2FSeE0e5uV+uoq6yqX2cLb0n2oKuUxlSXJyPXpFr9oii9 X-Gm-Gg: Acq92OErwPoaeCd1xqcaKrP8eqeb3bZkR6t7MbdIDNP8TvkJpkXUrzx39iOy1bPRBeo 4VQO6sFQc8tdjFxlcHCTyDbsAnjOUC+oVdDTFiVd2gH/Dd5PUtowCj6mkdvrZOr2DRC69smXxNw AHGNHKXSOUrP4+FDXi76UbQvnPC/f06RYuCIjmuPLGHL6ew1m6D/chVh9d7sFt6V/fX6Qnx5y+U moDn70mi2ZKqTYhNxLqjTnpcLK1v7hEEcBl8trMDnR8wN/0x7cknDD6bo3i7ptI/kcKlYW2dV4n vSw3jdpHsAZpkAtk4JNET4Gi/OUB1i40X448151AU7/RVjY4Z8dHrVj/FuINNbTSAtt7UoEFpkF s4iuAW20CNnYklp7ZowBbXRD7q4t+mzJqV9SmPgSId2QO7mgLtV979jn0rhY6w2+JdbUnSzNUjg B4w5+MdbPxvsycx9CyVgWzmLeEeyYH0A== X-Received: by 2002:a17:90b:134e:b0:368:5367:d681 with SMTP id 98e67ed59e1d1-369519c348cmr17621871a91.10.1779171312574; Mon, 18 May 2026 23:15:12 -0700 (PDT) Received: from [10.203.107.185] ([129.126.14.65]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3695124601asm12985043a91.2.2026.05.18.23.15.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 23:15:12 -0700 (PDT) Message-ID: <24280a77-8119-4b00-87e4-223ffded1b92@gmail.com> Date: Tue, 19 May 2026 14:15:09 +0800 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] btrfs: test qgroup deletion races with squota writes To: Boris Burkov Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com, fstests@vger.kernel.org References: <2c8668284ded13c7cc63ece213d9e1edc3e6ea85.1778632843.git.boris@bur.io> <20260518162841.GA3181893@zen.localdomain> Content-Language: en-US From: Anand Jain In-Reply-To: <20260518162841.GA3181893@zen.localdomain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Boris, The 7.1.0-rc3-gf5d9f327e4b2 kernel includes the for-next tree plus my latest f_fsid kernel patches. I double-checked and the required btrfs squota patches were indeed present: $ git log --oneline fs/btrfs | grep "check for subvolume before" 404bf5a24f2e btrfs: check for subvolume before deleting squota qgroup $ git log --oneline fs/btrfs | grep "forbid creating subvol qgroups" 0c309d66dacd btrfs: forbid creating subvol qgroups Possibly the issue was likely my messed-up VM image from SELinux + fanotifywait troubleshooting last evening. After a fresh restart, btrfs/348 passes: $ ./check -s gen btrfs/348 ... Ran: btrfs/348 Passed all 1 tests Sorry for the noise!. Looks good. Reviewed-by: Anand Jain A small nit (which can be fixed during merge). >>> diff --git a/tests/btrfs/348 b/tests/btrfs/348 >>> new file mode 100755 >>> index 00000000..ab816301 >>> --- /dev/null >>> +++ b/tests/btrfs/348 >>> @@ -0,0 +1,136 @@ >>> +#! /bin/bash >>> +# SPDX-License-Identifier: GPL-2.0 >>> +# Copyright (c) 2024 Meta Platforms, Inc. All Rights Reserved. Do you need this to be `s/2024/2026/` ? Thanks.