From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F293EC4338F for ; Tue, 17 Aug 2021 16:31:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D228960BD3 for ; Tue, 17 Aug 2021 16:31:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231438AbhHQQbq convert rfc822-to-8bit (ORCPT ); Tue, 17 Aug 2021 12:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231328AbhHQQbp (ORCPT ); Tue, 17 Aug 2021 12:31:45 -0400 Received: from mail.lichtvoll.de (lichtvoll.de [IPv6:2001:67c:14c:12f::11:100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD949C0613C1 for ; Tue, 17 Aug 2021 09:31:11 -0700 (PDT) Received: from ananda.localnet (unknown [IPv6:2001:a62:1a64:bb00:279:2943:e3ef:f04]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.lichtvoll.de (Postfix) with ESMTPSA id 02D9B2A3F24; Tue, 17 Aug 2021 18:31:05 +0200 (CEST) From: Martin Steigerwald To: Sebastian =?ISO-8859-1?Q?D=F6ring?= , Chris Murphy Cc: Btrfs BTRFS Subject: Re: Corruption errors on Samsung 980 Pro Date: Tue, 17 Aug 2021 18:31:05 +0200 Message-ID: <2461604.9INPc8UTF4@ananda> In-Reply-To: References: <2729231.WZja5ltl65@ananda> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Authentication-Results: mail.lichtvoll.de; auth=pass smtp.auth=martin2 smtp.mailfrom=martin@lichtvoll.de Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org Chris Murphy - 13.08.21, 20:14:40 CEST: > On Fri, Aug 13, 2021 at 3:50 AM Sebastian Döring wrote: > > >It is BTRFS single profile on LVM on LUKS. Mount options are: > > ... > > > > >I thought that a Samsung 980 Pro can easily handle "discard=async" > > >so I> > > used it. > > > > LUKS doesn't do discard unless you explicitly enable and force it. > > Have you? > `cryptsetup open` doesn't allow discards by default, but some distro > installers do enable it by default. The most likely place to find out > is looking at /etc/crypttab It has option "discard" in there. A few days ago BTRFS for /home had corruption errors that lead to it being marked read only and then being unmountable until I used "btrfs rescue zero-log". After that I was able to rsync almost all files to a freshly created BTRFS LVM LV and recover the rest from backup. This happened after an unintended laptop battery outage. But I better report it in a different thread. Best, -- Martin