Re: [PATCH 3/3] btrfs: update stale comment in __cow_file_range_inline()

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2025/12/15 20:08, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
> 
> We mention that the reserved data space is page size aligned but that's
> not true anymore, as it's sector size aligned instead.
> In commit 0bb067ca64e3 ("btrfs: fix the qgroup data free range for inline
> data extents") we updated the amount passed to btrfs_qgroup_free_data()
> from page size to sector size, but forgot to update the comment.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---
>   fs/btrfs/inode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index f1ead789146b..6ae36cc5bcda 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -676,7 +676,7 @@ static noinline int __cow_file_range_inline(struct btrfs_inode *inode,
>   	/*
>   	 * Don't forget to free the reserved space, as for inlined extent
>   	 * it won't count as data extent, free them directly here.
> -	 * And at reserve time, it's always aligned to page size, so
> +	 * And at reserve time, it's always aligned to sector size, so
>   	 * just free one page here.

There is still a "page" reference here.

Other than that it looks good to me.

Thanks,
Qu

>   	 *
>   	 * If we fallback to non-inline (ret == 1) due to -ENOSPC, then we need