From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix dev-replace after the scrub rework
Date: Thu, 1 Jun 2023 18:34:31 +0800 [thread overview]
Message-ID: <2563f49b-13e6-a33a-d3c8-3f5cdf01f0a6@gmx.com> (raw)
In-Reply-To: <20230601102217.GA10149@lst.de>
On 2023/6/1 18:22, Christoph Hellwig wrote:
> On Thu, Jun 01, 2023 at 06:12:12PM +0800, Qu Wenruo wrote:
>> Yes, the cleanup is also in my mind, but currently I prefer to do the
>> fix first in-place, then you can do the tide up after the more critical fix.
>
> There isn't really much of a difference in the diffstat between
> doing the consolidation and duplicating everything. So I don't
> think that's much of an argument.
Indeed, I'll update the patch to cleanup the call sites.
Thanks,
Qu
prev parent reply other threads:[~2023-06-01 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 9:10 [PATCH] btrfs: fix dev-replace after the scrub rework Qu Wenruo
2023-06-01 9:37 ` Christoph Hellwig
2023-06-01 10:12 ` Qu Wenruo
2023-06-01 10:22 ` Christoph Hellwig
2023-06-01 10:34 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2563f49b-13e6-a33a-d3c8-3f5cdf01f0a6@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox