Re: [PATCH v8 00/12] btrfs: scrub: use a more reader friendly code to implement scrub_simple_mirror()

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

On 2023/4/1 00:17, David Sterba wrote:
> On Fri, Mar 31, 2023 at 09:20:03AM +0800, Qu Wenruo wrote:
>> This series can be found in my github repo:
>>
>> https://github.com/adam900710/linux/tree/scrub_stripe
> 
> This also includes the cleanup branch so I'll use this as topic branch
> in for-next.

Thanks for that.

Just some questions inspired by the series.

[WAY TO CLEANUP]
Just want to ask what's the proper way to do the cleanup.

Christoph mentioned in other subsystems they accept huge cleanup as long 
as it's only deleting code, while in my series I did the split to try 
keep each cleanup small.

But the split itself sometimes introduced dead code which is only going 
to be removed later, and most of the time, such new code makes no sense 
other than for patch split.

So I'm wondering what's the proper way to do huge cleanup in btrfs.

[FUTURE SCRUB UPDATE]
There are still something I may want to do improving scrub.

One such objective is to enhance RAID56 scrubbing.

In that case, what branch should I base my code on?
Normally I would go misc-next, but the new scrub is only in for-next.

Thanks,
Qu