From: Johannes Thumshirn <jthumshirn@suse.de>
To: dsterba@suse.cz, David Sterba <dsterba@suse.com>,
Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()
Date: Mon, 3 Dec 2018 11:59:37 +0100 [thread overview]
Message-ID: <2601dad8-0a67-735d-c21e-0b950b10d28f@suse.de> (raw)
In-Reply-To: <20181128154150.GQ2842@twin.jikos.cz>
On 28/11/2018 16:41, David Sterba wrote:
> On Wed, Nov 28, 2018 at 09:54:55AM +0100, Johannes Thumshirn wrote:
>> In map_private_extent_buffer() use offset_in_page() to initialize
>> 'start_offset' instead of open-coding it.
>
> Can you please fix all instances where it's opencoded? Grepping for
> 'PAGE_SIZE - 1' finds a number of them. Thanks.
Sure will do.
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2018-12-03 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 8:54 [PATCH v2 0/3] Misc cosmetic changes for map_private_extent_buffer Johannes Thumshirn
2018-11-28 8:54 ` [PATCH v2 1/3] btrfs: don't initialize 'offset' in map_private_extent_buffer() Johannes Thumshirn
2018-11-28 8:54 ` [PATCH v2 2/3] btrfs: use offset_in_page for start_offset " Johannes Thumshirn
2018-11-28 15:41 ` David Sterba
2018-12-03 10:59 ` Johannes Thumshirn [this message]
2018-11-28 8:54 ` [PATCH v2 3/3] btrfs: document extent mapping assumptions in checksum Johannes Thumshirn
2018-11-28 8:58 ` Nikolay Borisov
2018-11-28 15:43 ` [PATCH v2 0/3] Misc cosmetic changes for map_private_extent_buffer David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601dad8-0a67-735d-c21e-0b950b10d28f@suse.de \
--to=jthumshirn@suse.de \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).