Re: [PATCH 0/3] btrfs-progs: selftests fixes

David Sterba
2022-10-06T15:30:40Z

On Wed, Oct 05, 2022 at 10:25:11AM +0800, Qu Wenruo wrote:
> There are 3 bugs exposed during my tests for unified mkfs features, and
> they are all from the selftest itself:
>
> - check_min_kernel_version() doesn't handle 6.x kernels at all
> The original check never handles major number check properly.
> And when we change major number, returns in correct number now.
>
> - Missing a space between "!" and function call
> This bug is there for a long time.
>
> Without previous fix, one may incorrectly remove the "!" and cause
> new problems.
>
> - Convert/022 doesn't check if we have support for reiserfs
>
> Qu Wenruo (3):
> btrfs-progs: tests: fix the wrong kernel version check
> btrfs-progs: mkfs-tests/025: fix the wrong function call
> btrfs-progs: convert-tests/022: add reiserfs support check

I've foled patch 2 to the one that that introduced it so we don't have
broken tests. The other two merged to devel, thanks.