Re: [PATCH 3/3] btrfs-progs: convert-tests/022: add reiserfs support check

David Sterba
2022-10-06T15:29:32Z

On Wed, Oct 05, 2022 at 10:25:14AM +0800, Qu Wenruo wrote:
> [BUG]
> Btrfs-progs test case convert/022 will fail if the system doesn't have
> reiserfs support nor reiserfs user space tools:
>
> # make TEST=022\* test-convert
> [TEST] convert-tests.sh
> WARNING: reiserfs filesystem not listed in /proc/filesystems, some tests might be skipped
> [TEST/conv] 022-reiserfs-parent-ref
> Failed system wide prerequisities: mkreiserfs
> test failed for case 022-reiserfs-parent-ref
> make: *** [Makefile:443: test-convert] Error 1
>
> [CAUSE]
> Unlike other test cases, convert/022 doesn't even check if we have
> kernel support for it.
>
> [FIX]
> Add the proper check before doing system wide prerequisities checks.

I've moved it before the mkreiserfs check, I'd like to keep the
setup_root_helper and prepare_test_dev first in the list for
consistency.