Re: [PATCH 2/3] btrfs-progs: mkfs-tests/025: fix the wrong function call

David Sterba
2022-10-05T11:52:17Z

On Wed, Oct 05, 2022 at 03:58:47PM +0800, Qu Wenruo wrote:
> On 2022/10/5 14:43, Wang Yugui wrote:
> >> tests/mkfs-tests/025-zoned-parallel/test.sh | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/mkfs-tests/025-zoned-parallel/test.sh b/tests/mkfs-tests/025-zoned-parallel/test.sh
> >> index 8cad906cd5d1..83274bb23447 100755
> >> --- a/tests/mkfs-tests/025-zoned-parallel/test.sh
> >> +++ b/tests/mkfs-tests/025-zoned-parallel/test.sh
> >> @@ -8,7 +8,7 @@ source "$TEST_TOP/common"
> >> setup_root_helper
> >> prepare_test_dev
> >>
> >> -if !check_min_kernel_version 5.12; then
> >> +if ! check_min_kernel_version 5.12; then
> >> _notrun "zoned tests need kernel 5.12 and newer"
> >> fi
> >
> > '_notrun' should be changed to '_not_run' too.
>
> That's right, I forgot this as my previous patch would render the path
> unreachable for newer kernels.
>
> David, can you fix it when merging?

Fixed and pushed, thanks.