Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 1/3] Btrfs: replace tree->mapping with tree->private_data
Date: Tue, 09 May 2017 11:48:41 +0530	[thread overview]
Message-ID: <2739487.yeMUBoeZhI@localhost.localdomain> (raw)
In-Reply-To: <1493999835-26731-2-git-send-email-jbacik@fb.com>

On Friday, May 05, 2017 11:57:13 AM Josef Bacik wrote:
> For extent_io tree's we have carried the address_mapping of the inode around in
> the io tree in order to pull the inode back out for calling into various tree
> ops hooks.  This works fine when everything that has an extent_io_tree has an
> inode.  But we are going to remove the btree_inode, so we need to change this.
> Instead just have a generic void * for private data that we can initialize with,
> and have all the tree ops use that instead.  This had a lot of cascading changes
> but should be relatively straightforward.
>

The changes look fine,

Reviewed-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>

-- 
chandan


  reply	other threads:[~2017-05-09  6:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 15:57 [PATCH 0/3] Kill btree inode prep patches Josef Bacik
2017-05-05 15:57 ` [PATCH 1/3] Btrfs: replace tree->mapping with tree->private_data Josef Bacik
2017-05-09  6:18   ` Chandan Rajendra [this message]
2017-05-09 14:59   ` David Sterba
2017-05-05 15:57 ` [PATCH 2/3] btrfs: remove inode argument from repair_io_failure Josef Bacik
2017-05-09  6:25   ` Chandan Rajendra
2017-05-09 15:00   ` David Sterba
2017-05-05 15:57 ` [PATCH 3/3] Btrfs: don't pass the inode through clean_io_failure Josef Bacik
2017-05-09  6:26   ` Chandan Rajendra
2017-05-09 15:00   ` David Sterba
2017-05-17 17:44 ` [PATCH 0/3] Kill btree inode prep patches David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2739487.yeMUBoeZhI@localhost.localdomain \
    --to=chandan@linux.vnet.ibm.com \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox