Re: [PATCH 0/8][v2] relocation error handling fixes

David Sterba
2020-03-13T14:36:16Z

On Wed, Mar 04, 2020 at 11:18:22AM -0500, Josef Bacik wrote:
> v1->v2:
> - Incorporated the various feedback, tweaked some things, adjusted commit
> messages, added some more comments. Hopefully I got everything.
> - Added "btrfs: do not init a reloc root if we aren't relocating", this is to
> oddress the weird handling of DEAD_ROOT and the use-after-free that Qu had
> originally attempted to fix.
> - Reworked "btrfs: splice rc->reloc_roots onto reloc roots in recover" to simply
> handle cleaning up any remaining bigs on the reloc_control, since errors can
> mean we'll have some things left pending on the reloc_control.

I've merged the reviewed patches to misc-next, but there are still
comments to 4 and 6, while 7, 8 could be fine as-is, at least 7 depends
on 6 so it might need changes too.

This the last batch of fixes I want to get in before merging the root
refs part 2. Both are in for-next so we have some testing coverage, but
the changelog for patch 6 is really insufficient.