Re: [PATCH 6/8] btrfs: clear BTRFS_ROOT_DEAD_RELOC_TREE before dropping the reloc root

Josef Bacik
2020-03-05T13:54:12Z

On 3/5/20 6:41 AM, Qu Wenruo wrote:
>
>
> On 2020/3/5 上午12:18, Josef Bacik wrote:
>> We were doing the clear dance for the reloc root after doing the drop of
>> the reloc root, which means we have a giant window where we could miss
>> having BTRFS_ROOT_DEAD_RELOC_TREE unset and the reloc_root == NULL.
>
> Still, I can't see the problem where we have BTRFS_ROOT_DEAD_RELOC_TREE
> and reloc_root == NULL.
>
> IMHO, that would cause anything wrong. Or is there anything I missed?
>

I was still hitting leaks and I was convinced it was because we were re-init'ing
the reloc root, but I think that line of reasoning is just wrong. I'll reword
the changelog, it's just a cosmetic thing at this point, not a real problem.
Thanks,

Josef