From: Anand Jain <anand.jain@oracle.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs test scan but not register the single device fs
Date: Fri, 6 Oct 2023 08:08:15 +0800 [thread overview]
Message-ID: <298af022-94bf-41ec-9ac5-ec560e7e9bac@oracle.com> (raw)
In-Reply-To: <20231005142911.edxcwtwnvywq4dn6@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
>> +$WIPEFS_PROG -a $SCRATCH_DEV
>
> _require_command "$WIPEFS_PROG" wipefs
>
>> +$WIPEFS_PROG -a $SPARE_DEV
>> +
>> +echo "#setup seed sprout device" >> $seqres.full
>> +_scratch_mkfs "-b 300M" >> $seqres.full 2>&1
>
> Better to with "|| _fail "....."", if we give specific options to _scratch_mkfs.
>
> Others look good to me, if no more review points from others, I'll merge
> this patch with above changes, and with
>
> Reviewed-by: Zorro Lang <zlang@redhat.com>
>
Agreed to both of the changes.
Thanks, Anand
prev parent reply other threads:[~2023-10-06 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 9:01 [PATCH] btrfs test scan but not register the single device fs Anand Jain
2023-10-05 8:12 ` Anand Jain
2023-10-05 14:29 ` Zorro Lang
2023-10-06 0:08 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=298af022-94bf-41ec-9ac5-ec560e7e9bac@oracle.com \
--to=anand.jain@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).