From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 833991F03D2 for ; Wed, 5 Mar 2025 07:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741160665; cv=none; b=ly8o7AjryS7tRkYaoIv/YeUhSLuLQqIzqK50ZayjoodYNIN3pBcUSiaJAmcdvwokZ7nB7stu0vu+F75M9AenpFp1O7wiAjMi4CrJjNY6vt+LpHuu/iBM1H2a4dUZW0xMNjhLqvY6u5CMbwiAu3bRIJyY9/2yD2gO+ZlI6Stj584= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741160665; c=relaxed/simple; bh=UrNgFfuy70+VwkPgxKQZ6ZdnvRh29b6/odukdfgIbj0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=howndhzp3ExNynFlGB6IpONREoQxhYdNLXmKe4u3YwsxNJGFvcdmh5b8gAuOVv2/JslPDeJSluYgygBeqwvtfgxyMndYtzOdXyn+WqV3sPHInbFoMQMBbxteRe+gOBzOFhilaSjFrfm8zwazCNbHnpOVGUFIEt98PfX1Op4t05A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Rgm7zUuT; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Rgm7zUuT" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5e4d3f92250so8888651a12.1 for ; Tue, 04 Mar 2025 23:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741160662; x=1741765462; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=1nldCz0GLZ3kYSpyVKXApLHSDBz6vCT9Ad7Pgzjf9wI=; b=Rgm7zUuTz+aU+Zkl3TcTyDR40rknetSkopNPCj/oSmxLfT35JjLSfnqAIQxD9gGFzs uDp5wuq34Gl1gVeC2LyMxLVy738NuD1kchn2SYU8qZBFdFGLoG6CbWoLuSKO0bt1QxGZ WNVVRVPRZ3O/FPz1mIaFdr7i6cHPJeQpSJnxVhyYzmEBXSIYabPJsbSLN+SKoiASpLEH Bjh1+ZA7jF19zBzw6kzKKOQVf0Vy6oc3J4crZD8MVTbwi3XghH7vSWXpmGWwzZfguYfV R/Y2XjjHDTUPTNFCN1PLz1U6sOSEfM95KxLDLZ0kUKygW85trDx1LL4lThhTgC89sFJr up7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741160662; x=1741765462; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1nldCz0GLZ3kYSpyVKXApLHSDBz6vCT9Ad7Pgzjf9wI=; b=W9LJeK9AEvsAzYFUBG5Qek+Gu/kQzsqe4kRbECUnen0kRiYjkyfv7GWS/Ehsv87j7f qdBCiJU5cvi/HlSO2PB9UT7UmxLJYY+uG8D8rRckHqawf1VqvXAqnLPRtgxYmdo74ocq 8xVcmYcJJN9F3H3oCfN6oRRJ3Z+6KMZ3aqHvd4CWNSuF0LYDttji/FlL8xGsViHBwWKF +5Sc7NBv10IDLcr6tl/M3s2p/OMFSU27CP0Ec0keLYID8ms1S97eV2nFnQR82C4ssorH 1TIQu93W5bSc95P/QftFt1IBp/vAaSJINt894b4FCiwFjNfBhjywOKowZs3+EgfMTe+j Foeg== X-Forwarded-Encrypted: i=1; AJvYcCXe1ZVV3vihGOE3A/1xDLmQiHyfm/8GRxs8MiCTVx/hP5x1vSxF7tFCtqCbNeMSr9N59tkLdj7AaTnh1w==@vger.kernel.org X-Gm-Message-State: AOJu0YzssmgSuzwoMJPKeOvjltgSAIdVk7eOTlndBsGZoqq9Y8hdyjar JkemMsjAHhRXDRZhT3JdfELqdObkY0ALP4g4ucKeuzFzGqxediwRq8q4DLX835o= X-Gm-Gg: ASbGncuONTgVs7EEkbhYINXABIHLY+7AXr2dIrNEW/Wi7ftkCpnEeuAGizh5J8olsJu mz87F0t0oWR2c3o9AEz6NxA9smRvCzuy+OQqkEFE1Ymjr/mwNPkSXkqYUBjV/7JatQfeqmi8+3Y MMubRGC+1X2/pEfK9uPO/XnJpVRgz40+28U0kZ36uCaQlqyrO8FHoNey78HRkvhFx9D1dtXcXer VGX+cGyIu8Oe0aDEb7HODYKk1PrEGhvi4l5iCs3KlYs/eI06bbtfh5WwmomvSG/q/XNZ/hpTPpk G70K7PlzITlFbGaQ0ik1pzwEikYkt/siZH5KhsIoakEW9NLedrLj3NwMBEb6M1SVGGKC1D5o X-Google-Smtp-Source: AGHT+IEDD9hLz++jtkr7mot50/VoADnGAIUOd5CuyJMU3KXlvgUIQG53kvXGhMENiPlw/k2p22uueg== X-Received: by 2002:a17:907:6d0f:b0:abf:d4a9:a09d with SMTP id a640c23a62f3a-ac20e02de81mr213786066b.47.1741160661447; Tue, 04 Mar 2025 23:44:21 -0800 (PST) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22350529edasm107223195ad.230.2025.03.04.23.44.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Mar 2025 23:44:20 -0800 (PST) Message-ID: <29ec66bd-27a0-443e-b19b-fb759a847dcb@suse.com> Date: Wed, 5 Mar 2025 18:14:16 +1030 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] btrfs/defrag: implement compression levels To: Daniel Vacek , Qu Wenruo Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250304171403.571335-1-neelx@suse.com> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2025/3/5 17:32, Daniel Vacek 写道: > On Tue, 4 Mar 2025 at 22:31, Qu Wenruo wrote: [...] >> >> I am not familiar with the compress level, but >> btrfs_compress_set_level() does extra clamping, maybe we also want to do >> that too? > > This is intentionally left to be limited later. There's no need to do > it at this point and the code is simpler. It's also compression > type/method agnostic. You're right, the level checks are done in the compression path already. [...] >>> /* spare for later */ >>> __u32 unused[4]; >> >> We have enough space left here, although u32 is overkilled for >> compress_type, using the unused space for a new s8/s16/s32 member should >> be fine. > > That is what I did originally, but discussing with Dave he suggested > this solution. Normally I would be fine with the union, to save some memory. Maybe I'm a little paranoid, but the defrag ioctl flag check is only introduced last year by commit 173431b274a9 ("btrfs: defrag: reject unknown flags of btrfs_ioctl_defrag_range_args"). So it's possible that some older kernels don't have that commit, and may incorrectly continue by ignoring the flag. Thankfully that should fail with -EINVAL (type always in the higher bits, thus always tricking the NR_COMPRESS_TYPES check. If that layout (type in higher bits, level in lower bits) is intentionally, I'd say it's very clever. Anyway either solution looks fine to me now. With that commit message fixed: Reviewed-by: Qu Wenruo Thanks, Qu > >> >> Thanks, >> Qu >