Re: [PATCH 08/17] btrfs: move discard stat defs to free-space-cache.h

[Qu Wenruo <wqu@suse.com>]

On 2022/9/14 23:06, Josef Bacik wrote:
> These definitions are used for discard statistics, move them out of
> ctree.h and put them in free-space-cache.h.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/ctree.h            | 9 ---------
>   fs/btrfs/free-space-cache.h | 9 +++++++++
>   2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index e1ec047deff6..2e6a947a48de 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -58,15 +58,6 @@ struct btrfs_ioctl_encoded_io_args;
>   
>   #define BTRFS_MAX_EXTENT_SIZE SZ_128M
>   
> -/*
> - * Deltas are an effective way to populate global statistics.  Give macro names
> - * to make it clear what we're doing.  An example is discard_extents in
> - * btrfs_free_space_ctl.
> - */
> -#define BTRFS_STAT_NR_ENTRIES	2
> -#define BTRFS_STAT_CURR		0
> -#define BTRFS_STAT_PREV		1
> -
>   static inline unsigned long btrfs_chunk_item_size(int num_stripes)
>   {
>   	BUG_ON(num_stripes == 0);
> diff --git a/fs/btrfs/free-space-cache.h b/fs/btrfs/free-space-cache.h
> index 6d419ba53e95..eaf30f6444dd 100644
> --- a/fs/btrfs/free-space-cache.h
> +++ b/fs/btrfs/free-space-cache.h
> @@ -43,6 +43,15 @@ static inline bool btrfs_free_space_trimming_bitmap(
>   	return (info->trim_state == BTRFS_TRIM_STATE_TRIMMING);
>   }
>   
> +/*
> + * Deltas are an effective way to populate global statistics.  Give macro names
> + * to make it clear what we're doing.  An example is discard_extents in
> + * btrfs_free_space_ctl.
> + */
> +#define BTRFS_STAT_NR_ENTRIES	2
> +#define BTRFS_STAT_CURR		0
> +#define BTRFS_STAT_PREV		1
> +
>   struct btrfs_free_space_ctl {
>   	spinlock_t tree_lock;
>   	struct rb_root free_space_offset;